X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;ds=sidebyside;f=lttng%2Fcommands%2Fenable_events.c;h=b99b7f4c942294784f577ea8465009aa2b0134c0;hb=8f0d098bc0b14f00c4d6ea3f48809626fa1c416f;hp=9657571473410558d15ea83d79f9aabd9baf8655;hpb=cf0e54677d2173cdcedf3e4163e264f4da7f3890;p=lttng-tools.git diff --git a/lttng/commands/enable_events.c b/lttng/commands/enable_events.c index 965757147..b99b7f4c9 100644 --- a/lttng/commands/enable_events.c +++ b/lttng/commands/enable_events.c @@ -25,6 +25,7 @@ #include #include #include +#include #include "../cmd.h" #include "../conf.h" @@ -40,7 +41,8 @@ static int opt_userspace; static int opt_enable_all; static pid_t opt_pid; static char *opt_probe; -static char *opt_function_symbol; +static char *opt_function; +static char *opt_function_entry_symbol; static char *opt_channel_name; enum { @@ -50,6 +52,7 @@ enum { OPT_MARKER, OPT_PROBE, OPT_FUNCTION, + OPT_FUNCTION_ENTRY, }; static struct poptOption long_options[] = { @@ -66,6 +69,7 @@ static struct poptOption long_options[] = { {"marker", 0, POPT_ARG_NONE, 0, OPT_MARKER, 0, 0}, {"probe", 0, POPT_ARG_STRING, 0, OPT_PROBE, 0, 0}, {"function", 0, POPT_ARG_STRING, 0, OPT_FUNCTION, 0, 0}, + {"function:entry", 0, POPT_ARG_STRING, 0, OPT_FUNCTION_ENTRY, 0, 0}, {0, 0, 0, 0, 0, 0, 0} }; @@ -87,11 +91,16 @@ static void usage(FILE *ofp) fprintf(ofp, "\n"); fprintf(ofp, "Event options:\n"); fprintf(ofp, " --tracepoint Tracepoint event (default)\n"); - fprintf(ofp, " --probe [addr | symbol+offset]\n"); + fprintf(ofp, " --probe [addr | symbol | symbol+offset]\n"); fprintf(ofp, " Dynamic probe.\n"); fprintf(ofp, " Addr and offset can be octal (0NNN...),\n"); fprintf(ofp, " decimal (NNN...) or hexadecimal (0xNNN...)\n"); - fprintf(ofp, " --function SYMBOL Function tracer event\n"); + fprintf(ofp, " --function [addr | symbol | symbol+offset]\n"); + fprintf(ofp, " Dynamic function entry/return probe.\n"); + fprintf(ofp, " Addr and offset can be octal (0NNN...),\n"); + fprintf(ofp, " decimal (NNN...) or hexadecimal (0xNNN...)\n"); + fprintf(ofp, " --function:entry symbol\n"); + fprintf(ofp, " Function tracer event\n"); fprintf(ofp, " --marker User-space marker (deprecated)\n"); fprintf(ofp, "\n"); } @@ -104,46 +113,62 @@ static void usage(FILE *ofp) static int parse_probe_opts(struct lttng_event *ev, char *opt) { int ret; - uint64_t hex; + char s_hex[19]; char name[LTTNG_SYMBOL_NAME_LEN]; if (opt == NULL) { ret = -1; - goto error; + goto end; } /* Check for symbol+offset */ - ret = sscanf(opt, "%[^'+']+%" SCNu64, name, &hex); + ret = sscanf(opt, "%[^'+']+%s", name, s_hex); if (ret == 2) { strncpy(ev->attr.probe.symbol_name, name, LTTNG_SYMBOL_NAME_LEN); DBG("probe symbol %s", ev->attr.probe.symbol_name); - if (hex == 0) { - ERR("Invalid probe offset %" PRIu64, hex); + if (strlen(s_hex) == 0) { + ERR("Invalid probe offset %s", s_hex); ret = -1; - goto error; + goto end; } - ev->attr.probe.offset = hex; + ev->attr.probe.offset = strtoul(s_hex, NULL, 0); DBG("probe offset %" PRIu64, ev->attr.probe.offset); - goto error; + ev->attr.probe.addr = 0; + goto end; + } + + /* Check for symbol */ + if (isalpha(name[0])) { + ret = sscanf(opt, "%s", name); + if (ret == 1) { + strncpy(ev->attr.probe.symbol_name, name, LTTNG_SYMBOL_NAME_LEN); + DBG("probe symbol %s", ev->attr.probe.symbol_name); + ev->attr.probe.offset = 0; + DBG("probe offset %" PRIu64, ev->attr.probe.offset); + ev->attr.probe.addr = 0; + goto end; + } } /* Check for address */ - ret = sscanf(opt, "%" SCNu64, &hex); + ret = sscanf(opt, "%s", s_hex); if (ret > 0) { - if (hex == 0) { - ERR("Invalid probe address %" PRIu64, hex); + if (strlen(s_hex) == 0) { + ERR("Invalid probe address %s", s_hex); ret = -1; - goto error; + goto end; } - ev->attr.probe.addr = hex; + ev->attr.probe.addr = strtoul(s_hex, NULL, 0); DBG("probe addr %" PRIu64, ev->attr.probe.addr); - goto error; + ev->attr.probe.offset = 0; + memset(ev->attr.probe.symbol_name, 0, LTTNG_SYMBOL_NAME_LEN); + goto end; } /* No match */ ret = -1; -error: +end: return ret; } @@ -159,11 +184,6 @@ static int enable_events(void) struct lttng_event ev; struct lttng_domain dom; - if (set_session_name(opt_session_name) < 0) { - ret = CMD_ERROR; - goto error; - } - if (opt_channel_name == NULL) { err = asprintf(&channel_name, DEFAULT_CHANNEL_NAME); if (err < 0) { @@ -180,6 +200,11 @@ static int enable_events(void) } if (opt_enable_all) { + if (set_session_name(opt_session_name) < 0) { + ret = CMD_ERROR; + goto error; + } + if (opt_kernel) { ret = lttng_enable_event(&dom, NULL, channel_name); if (ret == 0) { @@ -194,6 +219,11 @@ static int enable_events(void) /* Strip event list */ event_name = strtok(opt_event_list, ","); while (event_name != NULL) { + if (set_session_name(opt_session_name) < 0) { + ret = CMD_ERROR; + goto error; + } + /* Kernel tracer action */ if (opt_kernel) { DBG("Enabling kernel event %s for channel %s", @@ -214,7 +244,17 @@ static int enable_events(void) } break; case LTTNG_EVENT_FUNCTION: - strncpy(ev.attr.ftrace.symbol_name, opt_function_symbol, LTTNG_SYMBOL_NAME_LEN); + ret = parse_probe_opts(&ev, opt_function); + if (ret < 0) { + ERR("Unable to parse function probe options"); + ret = 0; + goto error; + } + break; + case LTTNG_EVENT_FUNCTION_ENTRY: + strncpy(ev.attr.ftrace.symbol_name, + opt_function_entry_symbol, + LTTNG_SYMBOL_NAME_LEN); break; default: ret = CMD_NOT_IMPLEMENTED; @@ -224,8 +264,6 @@ static int enable_events(void) ret = lttng_enable_event(&dom, &ev, channel_name); if (ret == 0) { MSG("Kernel event %s created in channel %s", event_name, channel_name); - } else if (ret < 0) { - ERR("Unable to find event %s", ev.name); } } else if (opt_userspace) { /* User-space tracer action */ /* @@ -290,7 +328,11 @@ int cmd_enable_events(int argc, const char **argv) break; case OPT_FUNCTION: opt_event_type = LTTNG_EVENT_FUNCTION; - opt_function_symbol = poptGetOptArg(pc); + opt_function = poptGetOptArg(pc); + break; + case OPT_FUNCTION_ENTRY: + opt_event_type = LTTNG_EVENT_FUNCTION_ENTRY; + opt_function_entry_symbol = poptGetOptArg(pc); break; default: usage(stderr);