X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;ds=sidebyside;f=liblttng-ust%2Flttng-events.c;h=140e5caeea00cb27f5ddfc9df055ba5fc171ad50;hb=60864af02c63fdaaf9264b4f14bfbc9f9fba64bd;hp=bf74a1d9cfc3ec48b13d04accda4d6303cafc4b3;hpb=a40b5b8cd4af87564b297e343de14779c1bfc11a;p=lttng-ust.git

diff --git a/liblttng-ust/lttng-events.c b/liblttng-ust/lttng-events.c
index bf74a1d9..140e5cae 100644
--- a/liblttng-ust/lttng-events.c
+++ b/liblttng-ust/lttng-events.c
@@ -53,6 +53,7 @@
 #include "ust-events-internal.h"
 #include "wait.h"
 #include "../libringbuffer/shm.h"
+#include "../libringbuffer/frontend_types.h"
 #include "../libcounter/counter.h"
 #include "jhash.h"
 #include <lttng/ust-abi.h>
@@ -83,6 +84,22 @@ void lttng_event_notifier_group_sync_enablers(
 static
 void lttng_enabler_destroy(struct lttng_enabler *enabler);
 
+bool lttng_ust_validate_event_name(const struct lttng_ust_event_desc *desc)
+{
+	if (strlen(desc->probe_desc->provider_name) + 1 +
+			strlen(desc->event_name) >= LTTNG_UST_ABI_SYM_NAME_LEN)
+		return false;
+	return true;
+}
+
+void lttng_ust_format_event_name(const struct lttng_ust_event_desc *desc,
+		char *name)
+{
+	strcpy(name, desc->probe_desc->provider_name);
+	strcat(name, ":");
+	strcat(name, desc->event_name);
+}
+
 /*
  * Called with ust lock held.
  */
@@ -237,8 +254,8 @@ void _lttng_channel_unmap(struct lttng_ust_channel_buffer *lttng_chan)
 
 	cds_list_del(&lttng_chan->priv->node);
 	lttng_destroy_context(lttng_chan->priv->ctx);
-	chan = lttng_chan->chan;
-	handle = lttng_chan->handle;
+	chan = lttng_chan->priv->rb_chan;
+	handle = chan->handle;
 	channel_destroy(chan, handle, 0);
 	free(lttng_chan->parent);
 	free(lttng_chan->priv);
@@ -250,10 +267,12 @@ void register_event(struct lttng_ust_event_common *event)
 {
 	int ret;
 	struct lttng_ust_event_desc *desc;
+	char name[LTTNG_UST_ABI_SYM_NAME_LEN];
 
 	assert(event->priv->registered == 0);
 	desc = event->priv->desc;
-	ret = lttng_ust_tp_probe_register_queue_release(desc->name,
+	lttng_ust_format_event_name(desc, name);
+	ret = lttng_ust_tp_probe_register_queue_release(name,
 			desc->probe_callback,
 			event, desc->signature);
 	WARN_ON_ONCE(ret);
@@ -266,10 +285,12 @@ void unregister_event(struct lttng_ust_event_common *event)
 {
 	int ret;
 	struct lttng_ust_event_desc *desc;
+	char name[LTTNG_UST_ABI_SYM_NAME_LEN];
 
 	assert(event->priv->registered == 1);
 	desc = event->priv->desc;
-	ret = lttng_ust_tp_probe_unregister_queue_release(desc->name,
+	lttng_ust_format_event_name(desc, name);
+	ret = lttng_ust_tp_probe_unregister_queue_release(name,
 			desc->probe_callback,
 			event);
 	WARN_ON_ONCE(ret);
@@ -676,14 +697,14 @@ struct cds_hlist_head *borrow_hash_table_bucket(
 		unsigned int hash_table_size,
 		struct lttng_ust_event_desc *desc)
 {
-	const char *event_name;
+	char name[LTTNG_UST_ABI_SYM_NAME_LEN];
 	size_t name_len;
 	uint32_t hash;
 
-	event_name = desc->name;
-	name_len = strlen(event_name);
+	lttng_ust_format_event_name(desc, name);
+	name_len = strlen(name);
 
-	hash = jhash(event_name, name_len, 0);
+	hash = jhash(name, name_len, 0);
 	return &hash_table[hash & (hash_table_size - 1)];
 }
 
@@ -694,6 +715,7 @@ static
 int lttng_event_recorder_create(struct lttng_ust_event_desc *desc,
 		struct lttng_ust_channel_buffer *chan)
 {
+	char name[LTTNG_UST_ABI_SYM_NAME_LEN];
 	struct lttng_ust_event_recorder *event_recorder;
 	struct lttng_ust_event_recorder_private *event_recorder_priv;
 	struct lttng_ust_session *session = chan->parent->session;
@@ -750,9 +772,10 @@ int lttng_event_recorder_create(struct lttng_ust_event_desc *desc,
 	event_recorder->chan = chan;
 
 	/* Event will be enabled by enabler sync. */
+	event_recorder->parent->run_filter = lttng_ust_interpret_event_filter;
 	event_recorder->parent->enabled = 0;
 	event_recorder->parent->priv->registered = 0;
-	CDS_INIT_LIST_HEAD(&event_recorder->parent->filter_bytecode_runtime_head);
+	CDS_INIT_LIST_HEAD(&event_recorder->parent->priv->filter_bytecode_runtime_head);
 	CDS_INIT_LIST_HEAD(&event_recorder->parent->priv->enablers_ref_head);
 	event_recorder->parent->priv->desc = desc;
 
@@ -765,12 +788,14 @@ int lttng_event_recorder_create(struct lttng_ust_event_desc *desc,
 	else
 		uri = NULL;
 
+	lttng_ust_format_event_name(desc, name);
+
 	/* Fetch event ID from sessiond */
 	ret = ustcomm_register_event(notify_socket,
 		session,
 		session->priv->objd,
 		chan->priv->parent.objd,
-		desc->name,
+		name,
 		loglevel,
 		desc->signature,
 		desc->nr_fields,
@@ -847,11 +872,12 @@ int lttng_event_notifier_create(struct lttng_ust_event_desc *desc,
 	event_notifier_priv->error_counter_index = error_counter_index;
 
 	/* Event notifier will be enabled by enabler sync. */
+	event_notifier->parent->run_filter = lttng_ust_interpret_event_filter;
 	event_notifier->parent->enabled = 0;
 	event_notifier_priv->parent.registered = 0;
 
-	CDS_INIT_LIST_HEAD(&event_notifier->parent->filter_bytecode_runtime_head);
-	CDS_INIT_LIST_HEAD(&event_notifier->capture_bytecode_runtime_head);
+	CDS_INIT_LIST_HEAD(&event_notifier->parent->priv->filter_bytecode_runtime_head);
+	CDS_INIT_LIST_HEAD(&event_notifier->priv->capture_bytecode_runtime_head);
 	CDS_INIT_LIST_HEAD(&event_notifier_priv->parent.enablers_ref_head);
 	event_notifier_priv->parent.desc = desc;
 	event_notifier->notification_send = lttng_event_notifier_notification_send;
@@ -874,12 +900,14 @@ static
 int lttng_desc_match_star_glob_enabler(struct lttng_ust_event_desc *desc,
 		struct lttng_enabler *enabler)
 {
+	char name[LTTNG_UST_ABI_SYM_NAME_LEN];
 	int loglevel = 0;
 	unsigned int has_loglevel = 0;
 
+	lttng_ust_format_event_name(desc, name);
 	assert(enabler->format_type == LTTNG_ENABLER_FORMAT_STAR_GLOB);
 	if (!strutils_star_glob_match(enabler->event_param.name, SIZE_MAX,
-			desc->name, SIZE_MAX))
+			name, SIZE_MAX))
 		return 0;
 	if (desc->loglevel) {
 		loglevel = *(*desc->loglevel);
@@ -897,11 +925,13 @@ static
 int lttng_desc_match_event_enabler(struct lttng_ust_event_desc *desc,
 		struct lttng_enabler *enabler)
 {
+	char name[LTTNG_UST_ABI_SYM_NAME_LEN];
 	int loglevel = 0;
 	unsigned int has_loglevel = 0;
 
+	lttng_ust_format_event_name(desc, name);
 	assert(enabler->format_type == LTTNG_ENABLER_FORMAT_EVENT);
-	if (strcmp(desc->name, enabler->event_param.name))
+	if (strcmp(name, enabler->event_param.name))
 		return 0;
 	if (desc->loglevel) {
 		loglevel = *(*desc->loglevel);
@@ -942,8 +972,14 @@ int lttng_desc_match_enabler(struct lttng_ust_event_desc *desc,
 				excluder_name = (char *) (excluder->excluder.names)
 						+ count * LTTNG_UST_ABI_SYM_NAME_LEN;
 				len = strnlen(excluder_name, LTTNG_UST_ABI_SYM_NAME_LEN);
-				if (len > 0 && strutils_star_glob_match(excluder_name, len, desc->name, SIZE_MAX))
-					return 0;
+				if (len > 0) {
+					char name[LTTNG_UST_ABI_SYM_NAME_LEN];
+
+					lttng_ust_format_event_name(desc, name);
+					if (strutils_star_glob_match(excluder_name, len, name, SIZE_MAX)) {
+						return 0;
+					}
+				}
 			}
 		}
 		return 1;
@@ -1049,8 +1085,9 @@ void lttng_create_event_recorder_if_missing(struct lttng_event_enabler *event_en
 			ret = lttng_event_recorder_create(probe_desc->event_desc[i],
 					event_enabler->chan);
 			if (ret) {
-				DBG("Unable to create event %s, error %d\n",
-					probe_desc->event_desc[i]->name, ret);
+				DBG("Unable to create event \"%s:%s\", error %d\n",
+					probe_desc->provider_name,
+					probe_desc->event_desc[i]->event_name, ret);
 			}
 		}
 	}
@@ -1238,7 +1275,7 @@ int lttng_event_enabler_ref_event_recorders(struct lttng_event_enabler *event_en
 		 */
 		lttng_enabler_link_bytecode(event_recorder_priv->parent.desc,
 			&session->priv->ctx,
-			&event_recorder_priv->pub->parent->filter_bytecode_runtime_head,
+			&event_recorder_priv->parent.filter_bytecode_runtime_head,
 			&lttng_event_enabler_as_enabler(event_enabler)->filter_bytecode_head);
 
 		/* TODO: merge event context. */
@@ -1654,7 +1691,8 @@ void lttng_session_sync_event_enablers(struct lttng_ust_session *session)
 	cds_list_for_each_entry(event_recorder_priv, &session->priv->events_head, node) {
 		struct lttng_enabler_ref *enabler_ref;
 		struct lttng_ust_bytecode_runtime *runtime;
-		int enabled = 0, has_enablers_without_bytecode = 0;
+		int enabled = 0, has_enablers_without_filter_bytecode = 0;
+		int nr_filters = 0;
 
 		/* Enable events */
 		cds_list_for_each_entry(enabler_ref,
@@ -1689,18 +1727,21 @@ void lttng_session_sync_event_enablers(struct lttng_ust_session *session)
 				&event_recorder_priv->parent.enablers_ref_head, node) {
 			if (enabler_ref->ref->enabled
 					&& cds_list_empty(&enabler_ref->ref->filter_bytecode_head)) {
-				has_enablers_without_bytecode = 1;
+				has_enablers_without_filter_bytecode = 1;
 				break;
 			}
 		}
-		event_recorder_priv->pub->parent->has_enablers_without_bytecode =
-			has_enablers_without_bytecode;
+		event_recorder_priv->parent.has_enablers_without_filter_bytecode =
+			has_enablers_without_filter_bytecode;
 
 		/* Enable filters */
 		cds_list_for_each_entry(runtime,
-				&event_recorder_priv->pub->parent->filter_bytecode_runtime_head, node) {
-			lttng_bytecode_filter_sync_state(runtime);
+				&event_recorder_priv->parent.filter_bytecode_runtime_head, node) {
+			lttng_bytecode_sync_state(runtime);
+			nr_filters++;
 		}
+		CMM_STORE_SHARED(event_recorder_priv->parent.pub->eval_filter,
+			!(has_enablers_without_filter_bytecode || !nr_filters));
 	}
 	lttng_ust_tp_probe_prune_release_queue();
 }
@@ -1765,12 +1806,12 @@ void lttng_create_event_notifier_if_missing(
 
 			/* Check that the probe supports event notifiers, else report the error. */
 			if (!lttng_ust_probe_supports_event_notifier(probe_desc)) {
-				ERR("Probe \"%s\" contains event \"%s\" which matches an enabled event notifier, "
+				ERR("Probe \"%s\" contains event \"%s:%s\" which matches an enabled event notifier, "
 					"but its version (%u.%u) is too old and does not implement event notifiers. "
 					"It needs to be recompiled against a newer version of LTTng-UST, otherwise "
 					"this event will not generate any notification.",
-					probe_desc->provider,
-					desc->name,
+					probe_desc->provider_name,
+					probe_desc->provider_name, desc->event_name,
 					probe_desc->major,
 					probe_desc->minor);
 				continue;
@@ -1783,8 +1824,9 @@ void lttng_create_event_notifier_if_missing(
 				event_notifier_enabler->error_counter_index,
 				event_notifier_group);
 			if (ret) {
-				DBG("Unable to create event_notifier %s, error %d\n",
-					probe_desc->event_desc[i]->name, ret);
+				DBG("Unable to create event_notifier \"%s:%s\", error %d\n",
+					probe_desc->provider_name,
+					probe_desc->event_desc[i]->event_name, ret);
 			}
 		}
 	}
@@ -1840,14 +1882,14 @@ int lttng_event_notifier_enabler_ref_event_notifiers(
 		 */
 		lttng_enabler_link_bytecode(event_notifier_priv->parent.desc,
 			&event_notifier_group->ctx,
-			&event_notifier_priv->pub->parent->filter_bytecode_runtime_head,
+			&event_notifier_priv->parent.filter_bytecode_runtime_head,
 			&lttng_event_notifier_enabler_as_enabler(event_notifier_enabler)->filter_bytecode_head);
 
 		/*
 		 * Link capture bytecodes if not linked yet.
 		 */
 		lttng_enabler_link_bytecode(event_notifier_priv->parent.desc,
-			&event_notifier_group->ctx, &event_notifier_priv->pub->capture_bytecode_runtime_head,
+			&event_notifier_group->ctx, &event_notifier_priv->capture_bytecode_runtime_head,
 			&event_notifier_enabler->capture_bytecode_head);
 
 		event_notifier_priv->num_captures = event_notifier_enabler->num_captures;
@@ -1872,7 +1914,8 @@ void lttng_event_notifier_group_sync_enablers(struct lttng_event_notifier_group
 	cds_list_for_each_entry(event_notifier_priv, &event_notifier_group->event_notifiers_head, node) {
 		struct lttng_enabler_ref *enabler_ref;
 		struct lttng_ust_bytecode_runtime *runtime;
-		int enabled = 0, has_enablers_without_bytecode = 0;
+		int enabled = 0, has_enablers_without_filter_bytecode = 0;
+		int nr_filters = 0, nr_captures = 0;
 
 		/* Enable event_notifiers */
 		cds_list_for_each_entry(enabler_ref,
@@ -1901,24 +1944,30 @@ void lttng_event_notifier_group_sync_enablers(struct lttng_event_notifier_group
 				&event_notifier_priv->parent.enablers_ref_head, node) {
 			if (enabler_ref->ref->enabled
 					&& cds_list_empty(&enabler_ref->ref->filter_bytecode_head)) {
-				has_enablers_without_bytecode = 1;
+				has_enablers_without_filter_bytecode = 1;
 				break;
 			}
 		}
-		event_notifier_priv->pub->parent->has_enablers_without_bytecode =
-			has_enablers_without_bytecode;
+		event_notifier_priv->parent.has_enablers_without_filter_bytecode =
+			has_enablers_without_filter_bytecode;
 
 		/* Enable filters */
 		cds_list_for_each_entry(runtime,
-				&event_notifier_priv->pub->parent->filter_bytecode_runtime_head, node) {
-			lttng_bytecode_filter_sync_state(runtime);
+				&event_notifier_priv->parent.filter_bytecode_runtime_head, node) {
+			lttng_bytecode_sync_state(runtime);
+			nr_filters++;
 		}
+		CMM_STORE_SHARED(event_notifier_priv->parent.pub->eval_filter,
+			!(has_enablers_without_filter_bytecode || !nr_filters));
 
 		/* Enable captures. */
 		cds_list_for_each_entry(runtime,
-				&event_notifier_priv->pub->capture_bytecode_runtime_head, node) {
-			lttng_bytecode_capture_sync_state(runtime);
+				&event_notifier_priv->capture_bytecode_runtime_head, node) {
+			lttng_bytecode_sync_state(runtime);
+			nr_captures++;
 		}
+		CMM_STORE_SHARED(event_notifier_priv->pub->eval_capture,
+				!!nr_captures);
 	}
 	lttng_ust_tp_probe_prune_release_queue();
 }
@@ -2006,3 +2055,21 @@ void lttng_ust_context_set_event_notifier_group_provider(const char *name,
 			abort();
 	}
 }
+
+int lttng_ust_session_uuid_validate(struct lttng_ust_session *session,
+		unsigned char *uuid)
+{
+	if (!session)
+		return 0;
+	/* Compare UUID with session. */
+	if (session->priv->uuid_set) {
+		if (memcmp(session->priv->uuid, uuid, LTTNG_UST_UUID_LEN)) {
+			return -1;
+		}
+	} else {
+		memcpy(session->priv->uuid, uuid, LTTNG_UST_UUID_LEN);
+		session->priv->uuid_set = true;
+	}
+	return 0;
+
+}