mutex_lock(&sessions_mutex);
WRITE_ONCE(session->active, 0);
list_for_each_entry(chan, &session->chan, list) {
- ret = lttng_syscalls_unregister_event(chan);
+ ret = lttng_syscalls_unregister_channel(chan);
WARN_ON(ret);
}
list_for_each_entry(event, &session->events, list) {
mutex_lock(&sessions_mutex);
- ret = lttng_syscalls_unregister_event_notifier(event_notifier_group);
+ ret = lttng_syscalls_unregister_event_notifier_group(event_notifier_group);
WARN_ON(ret);
list_for_each_entry_safe(event_notifier, tmpevent_notifier,
if (event_notifier_group->error_counter) {
struct lttng_counter *error_counter = event_notifier_group->error_counter;
+
error_counter->ops->counter_destroy(error_counter->counter);
module_put(error_counter->transport->owner);
lttng_kvfree(error_counter);
void *filter, enum lttng_kernel_instrumentation itype)
{
struct lttng_event_notifier *event_notifier;
+ struct lttng_counter *error_counter;
const char *event_name;
struct hlist_head *head;
int ret;
/*
* Clear the error counter bucket. The sessiond keeps track of which
- * bucket is currently in use. We trust it.
+ * bucket is currently in use. We trust it. The session lock
+ * synchronizes against concurrent creation of the error
+ * counter.
*/
- if (event_notifier_group->error_counter) {
+ error_counter = event_notifier_group->error_counter;
+ if (error_counter) {
size_t dimension_index[1];
/*
}
dimension_index[0] = event_notifier->error_counter_index;
- ret = event_notifier_group->error_counter->ops->counter_clear(
- event_notifier_group->error_counter->counter,
- dimension_index);
+ ret = error_counter->ops->counter_clear(error_counter->counter, dimension_index);
if (ret) {
printk(KERN_INFO "LTTng: event_notifier: Unable to clear error counter bucket %llu\n",
event_notifier->error_counter_index);
{
int ret;
- ret = lttng_syscalls_register_event(event_enabler->chan, NULL);
+ ret = lttng_syscalls_register_event(event_enabler, NULL);
WARN_ON_ONCE(ret);
}
struct lttng_event *event;
if (base_enabler->event_param.instrumentation == LTTNG_KERNEL_SYSCALL &&
- base_enabler->event_param.u.syscall.entryexit == LTTNG_KERNEL_SYSCALL_ENTRYEXIT &&
base_enabler->event_param.u.syscall.abi == LTTNG_KERNEL_SYSCALL_ABI_ALL &&
base_enabler->event_param.u.syscall.match == LTTNG_KERNEL_SYSCALL_MATCH_NAME &&
!strcmp(base_enabler->event_param.name, "*")) {
- if (base_enabler->enabled)
- WRITE_ONCE(chan->syscall_all, 1);
- else
- WRITE_ONCE(chan->syscall_all, 0);
+ int enabled = base_enabler->enabled;
+ enum lttng_kernel_syscall_entryexit entryexit = base_enabler->event_param.u.syscall.entryexit;
+
+ if (entryexit == LTTNG_KERNEL_SYSCALL_ENTRY || entryexit == LTTNG_KERNEL_SYSCALL_ENTRYEXIT)
+ WRITE_ONCE(chan->syscall_all_entry, enabled);
+
+ if (entryexit == LTTNG_KERNEL_SYSCALL_EXIT || entryexit == LTTNG_KERNEL_SYSCALL_ENTRYEXIT)
+ WRITE_ONCE(chan->syscall_all_exit, enabled);
}
/* First ensure that probe events are created for this enabler. */