Refactoring: introduce lttng_get_event_ht_from_enabler
[lttng-modules.git] / src / lttng-events.c
index 28df29fef012c70e91cf70f18c2c63a4ed132c1d..039b43e6ffb21f82c9dc864a5c89652aba200a93 100644 (file)
@@ -321,8 +321,8 @@ struct lttng_event_notifier_group *lttng_event_notifier_group_create(void)
 
        INIT_LIST_HEAD(&event_notifier_group->enablers_head);
        INIT_LIST_HEAD(&event_notifier_group->event_notifiers_head);
-       for (i = 0; i < LTTNG_EVENT_NOTIFIER_HT_SIZE; i++)
-               INIT_HLIST_HEAD(&event_notifier_group->event_notifiers_ht.table[i]);
+       for (i = 0; i < LTTNG_EVENT_HT_SIZE; i++)
+               INIT_HLIST_HEAD(&event_notifier_group->events_ht.table[i]);
 
        list_add(&event_notifier_group->node, &event_notifier_groups);
 
@@ -875,12 +875,13 @@ void _lttng_metadata_channel_hangup(struct lttng_metadata_stream *stream)
 struct lttng_kernel_event_recorder *_lttng_kernel_event_recorder_create(struct lttng_event_recorder_enabler *event_enabler,
                                const struct lttng_kernel_event_desc *event_desc)
 {
+       struct lttng_event_ht *events_ht = lttng_get_event_ht_from_enabler(&event_enabler->parent);
        struct lttng_kernel_channel_buffer *chan = event_enabler->chan;
        struct lttng_kernel_abi_event *event_param = &event_enabler->parent.event_param;
        enum lttng_kernel_abi_instrumentation itype = event_param->instrumentation;
-       struct lttng_kernel_session *session = chan->parent.session;
        struct lttng_kernel_event_recorder *event_recorder;
        struct lttng_kernel_event_recorder_private *event_recorder_priv;
+       struct lttng_kernel_event_common_private *event_priv;
        const char *event_name;
        struct hlist_head *head;
        int ret;
@@ -915,11 +916,12 @@ struct lttng_kernel_event_recorder *_lttng_kernel_event_recorder_create(struct l
                goto type_error;
        }
 
-       head = utils_borrow_hash_table_bucket(session->priv->events_ht.table,
-               LTTNG_EVENT_HT_SIZE, event_name);
-       lttng_hlist_for_each_entry(event_recorder_priv, head, hlist) {
-               WARN_ON_ONCE(!event_recorder_priv->parent.desc);
-               if (!strncmp(event_recorder_priv->parent.desc->event_name, event_name,
+       head = utils_borrow_hash_table_bucket(events_ht->table, LTTNG_EVENT_HT_SIZE, event_name);
+       lttng_hlist_for_each_entry(event_priv, head, hlist_node) {
+               event_recorder_priv = container_of(event_priv, struct lttng_kernel_event_recorder_private, parent);
+
+               WARN_ON_ONCE(!event_priv->desc);
+               if (!strncmp(event_priv->desc->event_name, event_name,
                                        LTTNG_KERNEL_ABI_SYM_NAME_LEN - 1)
                                && chan == event_recorder_priv->pub->chan) {
                        ret = -EEXIST;
@@ -1134,7 +1136,7 @@ struct lttng_kernel_event_recorder *_lttng_kernel_event_recorder_create(struct l
        if (ret) {
                goto statedump_error;
        }
-       hlist_add_head(&event_recorder->priv->hlist, head);
+       hlist_add_head(&event_recorder->priv->parent.hlist_node, head);
        list_add(&event_recorder->priv->node, &chan->parent.session->priv->events);
        return event_recorder;
 
@@ -1151,15 +1153,17 @@ full:
        return ERR_PTR(ret);
 }
 
-struct lttng_kernel_event_notifier *_lttng_event_notifier_create(
-               const struct lttng_kernel_event_desc *event_desc,
-               uint64_t token, uint64_t error_counter_index,
-               struct lttng_event_notifier_group *event_notifier_group,
-               struct lttng_kernel_abi_event_notifier *event_notifier_param,
-               enum lttng_kernel_abi_instrumentation itype)
+struct lttng_kernel_event_notifier *_lttng_event_notifier_create(struct lttng_event_notifier_enabler *event_enabler,
+               const struct lttng_kernel_event_desc *event_desc)
 {
+       struct lttng_event_ht *events_ht = lttng_get_event_ht_from_enabler(&event_enabler->parent);
+       struct lttng_event_notifier_group *event_notifier_group = event_enabler->group;
+       struct lttng_kernel_abi_event *event_param = &event_enabler->parent.event_param;
+       uint64_t token = event_enabler->parent.user_token;
+       enum lttng_kernel_abi_instrumentation itype = event_param->instrumentation;
        struct lttng_kernel_event_notifier *event_notifier;
        struct lttng_kernel_event_notifier_private *event_notifier_priv;
+       struct lttng_kernel_event_common_private *event_priv;
        struct lttng_counter *error_counter;
        const char *event_name;
        struct hlist_head *head;
@@ -1175,7 +1179,7 @@ struct lttng_kernel_event_notifier *_lttng_event_notifier_create(
        case LTTNG_KERNEL_ABI_UPROBE:
                lttng_fallthrough;
        case LTTNG_KERNEL_ABI_SYSCALL:
-               event_name = event_notifier_param->event.name;
+               event_name = event_param->name;
                break;
 
        case LTTNG_KERNEL_ABI_KRETPROBE:
@@ -1190,14 +1194,15 @@ struct lttng_kernel_event_notifier *_lttng_event_notifier_create(
                goto type_error;
        }
 
-       head = utils_borrow_hash_table_bucket(event_notifier_group->event_notifiers_ht.table,
-               LTTNG_EVENT_NOTIFIER_HT_SIZE, event_name);
-       lttng_hlist_for_each_entry(event_notifier_priv, head, hlist) {
-               WARN_ON_ONCE(!event_notifier_priv->parent.desc);
-               if (!strncmp(event_notifier_priv->parent.desc->event_name, event_name,
+       head = utils_borrow_hash_table_bucket(events_ht->table, LTTNG_EVENT_HT_SIZE, event_name);
+       lttng_hlist_for_each_entry(event_priv, head, hlist_node) {
+               event_notifier_priv = container_of(event_priv, struct lttng_kernel_event_notifier_private, parent);
+
+               WARN_ON_ONCE(!event_priv->desc);
+               if (!strncmp(event_priv->desc->event_name, event_name,
                                        LTTNG_KERNEL_ABI_SYM_NAME_LEN - 1)
                                && event_notifier_group == event_notifier_priv->group
-                               && token == event_notifier_priv->parent.user_token) {
+                               && token == event_priv->user_token) {
                        ret = -EEXIST;
                        goto exist;
                }
@@ -1220,8 +1225,8 @@ struct lttng_kernel_event_notifier *_lttng_event_notifier_create(
        event_notifier->parent.type = LTTNG_KERNEL_EVENT_TYPE_NOTIFIER;
 
        event_notifier->priv->group = event_notifier_group;
-       event_notifier->priv->parent.user_token = token;
-       event_notifier->priv->error_counter_index = error_counter_index;
+       event_notifier->priv->parent.user_token = event_enabler->parent.user_token;
+       event_notifier->priv->error_counter_index = event_enabler->error_counter_index;
        event_notifier->priv->num_captures = 0;
        event_notifier->priv->parent.instrumentation = itype;
        event_notifier->notification_send = lttng_event_notifier_notification_send;
@@ -1256,10 +1261,10 @@ struct lttng_kernel_event_notifier *_lttng_event_notifier_create(
                 * registration.
                 */
                smp_wmb();
-               ret = lttng_kprobes_register_event(event_notifier_param->event.u.kprobe.symbol_name,
-                               event_notifier_param->event.u.kprobe.symbol_name,
-                               event_notifier_param->event.u.kprobe.offset,
-                               event_notifier_param->event.u.kprobe.addr,
+               ret = lttng_kprobes_register_event(event_param->u.kprobe.symbol_name,
+                               event_param->u.kprobe.symbol_name,
+                               event_param->u.kprobe.offset,
+                               event_param->u.kprobe.addr,
                                &event_notifier->parent);
                if (ret) {
                        ret = -EINVAL;
@@ -1277,7 +1282,7 @@ struct lttng_kernel_event_notifier *_lttng_event_notifier_create(
                event_notifier->parent.enabled = 0;
                event_notifier->priv->parent.registered = 0;
                event_notifier->priv->parent.desc = event_desc;
-               switch (event_notifier_param->event.u.syscall.entryexit) {
+               switch (event_param->u.syscall.entryexit) {
                case LTTNG_KERNEL_ABI_SYSCALL_ENTRYEXIT:
                        ret = -EINVAL;
                        goto register_error;
@@ -1288,7 +1293,7 @@ struct lttng_kernel_event_notifier *_lttng_event_notifier_create(
                        event_notifier->priv->parent.u.syscall.entryexit = LTTNG_SYSCALL_EXIT;
                        break;
                }
-               switch (event_notifier_param->event.u.syscall.abi) {
+               switch (event_param->u.syscall.abi) {
                case LTTNG_KERNEL_ABI_SYSCALL_ABI_ALL:
                        ret = -EINVAL;
                        goto register_error;
@@ -1320,8 +1325,8 @@ struct lttng_kernel_event_notifier *_lttng_event_notifier_create(
                 */
                smp_wmb();
 
-               ret = lttng_uprobes_register_event(event_notifier_param->event.name,
-                               event_notifier_param->event.u.uprobe.fd,
+               ret = lttng_uprobes_register_event(event_param->name,
+                               event_param->u.uprobe.fd,
                                &event_notifier->parent);
                if (ret)
                        goto register_error;
@@ -1342,7 +1347,7 @@ struct lttng_kernel_event_notifier *_lttng_event_notifier_create(
        }
 
        list_add(&event_notifier->priv->node, &event_notifier_group->event_notifiers_head);
-       hlist_add_head(&event_notifier->priv->hlist, head);
+       hlist_add_head(&event_notifier->priv->parent.hlist_node, head);
 
        /*
         * Clear the error counter bucket. The sessiond keeps track of which
@@ -1418,19 +1423,13 @@ struct lttng_kernel_event_recorder *lttng_kernel_event_recorder_create(struct lt
        return event;
 }
 
-struct lttng_kernel_event_notifier *lttng_event_notifier_create(
-               const struct lttng_kernel_event_desc *event_desc,
-               uint64_t id, uint64_t error_counter_index,
-               struct lttng_event_notifier_group *event_notifier_group,
-               struct lttng_kernel_abi_event_notifier *event_notifier_param,
-               enum lttng_kernel_abi_instrumentation itype)
+struct lttng_kernel_event_notifier *lttng_event_notifier_create(struct lttng_event_notifier_enabler *event_enabler,
+               const struct lttng_kernel_event_desc *event_desc)
 {
        struct lttng_kernel_event_notifier *event_notifier;
 
        mutex_lock(&sessions_mutex);
-       event_notifier = _lttng_event_notifier_create(event_desc, id,
-               error_counter_index, event_notifier_group,
-               event_notifier_param, itype);
+       event_notifier = _lttng_event_notifier_create(event_enabler, event_desc);
        mutex_unlock(&sessions_mutex);
        return event_notifier;
 }
@@ -2061,7 +2060,7 @@ struct lttng_enabler_ref *lttng_enabler_ref(
 static
 void lttng_create_tracepoint_event_if_missing(struct lttng_event_recorder_enabler *event_enabler)
 {
-       struct lttng_kernel_session *session = event_enabler->chan->parent.session;
+       struct lttng_event_ht *events_ht = lttng_get_event_ht_from_enabler(&event_enabler->parent);
        struct lttng_kernel_probe_desc *probe_desc;
        const struct lttng_kernel_event_desc *desc;
        int i;
@@ -2077,8 +2076,9 @@ void lttng_create_tracepoint_event_if_missing(struct lttng_event_recorder_enable
                for (i = 0; i < probe_desc->nr_events; i++) {
                        int found = 0;
                        struct hlist_head *head;
-                       struct lttng_kernel_event_recorder_private *event_recorder_private;
+                       struct lttng_kernel_event_recorder_private *event_recorder_priv;
                        struct lttng_kernel_event_recorder *event_recorder;
+                       struct lttng_kernel_event_common_private *event_priv;
 
                        desc = probe_desc->event_desc[i];
                        if (!lttng_desc_match_enabler(desc,
@@ -2088,12 +2088,11 @@ void lttng_create_tracepoint_event_if_missing(struct lttng_event_recorder_enable
                        /*
                         * Check if already created.
                         */
-                       head = utils_borrow_hash_table_bucket(
-                               session->priv->events_ht.table, LTTNG_EVENT_HT_SIZE,
-                               desc->event_name);
-                       lttng_hlist_for_each_entry(event_recorder_private, head, hlist) {
-                               if (event_recorder_private->parent.desc == desc
-                                               && event_recorder_private->pub->chan == event_enabler->chan)
+                       head = utils_borrow_hash_table_bucket(events_ht->table, LTTNG_EVENT_HT_SIZE, desc->event_name);
+                       lttng_hlist_for_each_entry(event_priv, head, hlist_node) {
+                               event_recorder_priv = container_of(event_priv, struct lttng_kernel_event_recorder_private, parent);
+                               if (event_priv->desc == desc
+                                               && event_recorder_priv->pub->chan == event_enabler->chan)
                                        found = 1;
                        }
                        if (found)
@@ -2115,7 +2114,7 @@ void lttng_create_tracepoint_event_if_missing(struct lttng_event_recorder_enable
 static
 void lttng_create_tracepoint_event_notifier_if_missing(struct lttng_event_notifier_enabler *event_notifier_enabler)
 {
-       struct lttng_event_notifier_group *event_notifier_group = event_notifier_enabler->group;
+       struct lttng_event_ht *events_ht = lttng_get_event_ht_from_enabler(&event_notifier_enabler->parent);
        struct lttng_kernel_probe_desc *probe_desc;
        const struct lttng_kernel_event_desc *desc;
        int i;
@@ -2131,8 +2130,8 @@ void lttng_create_tracepoint_event_notifier_if_missing(struct lttng_event_notifi
                for (i = 0; i < probe_desc->nr_events; i++) {
                        int found = 0;
                        struct hlist_head *head;
-                       struct lttng_kernel_event_notifier_private *event_notifier_priv;
                        struct lttng_kernel_event_notifier *event_notifier;
+                       struct lttng_kernel_event_common_private *event_priv;
 
                        desc = probe_desc->event_desc[i];
                        if (!lttng_desc_match_enabler(desc,
@@ -2142,12 +2141,11 @@ void lttng_create_tracepoint_event_notifier_if_missing(struct lttng_event_notifi
                        /*
                         * Check if already created.
                         */
-                       head = utils_borrow_hash_table_bucket(
-                               event_notifier_group->event_notifiers_ht.table,
-                               LTTNG_EVENT_NOTIFIER_HT_SIZE, desc->event_name);
-                       lttng_hlist_for_each_entry(event_notifier_priv, head, hlist) {
-                               if (event_notifier_priv->parent.desc == desc
-                                               && event_notifier_priv->parent.user_token == event_notifier_enabler->parent.user_token)
+                       head = utils_borrow_hash_table_bucket(events_ht->table,
+                               LTTNG_EVENT_HT_SIZE, desc->event_name);
+                       lttng_hlist_for_each_entry(event_priv, head, hlist_node) {
+                               if (event_priv->desc == desc
+                                               && event_priv->user_token == event_notifier_enabler->parent.user_token)
                                        found = 1;
                        }
                        if (found)
@@ -2156,11 +2154,7 @@ void lttng_create_tracepoint_event_notifier_if_missing(struct lttng_event_notifi
                        /*
                         * We need to create a event_notifier for this event probe.
                         */
-                       event_notifier = _lttng_event_notifier_create(desc,
-                               event_notifier_enabler->parent.user_token,
-                               event_notifier_enabler->error_counter_index,
-                               event_notifier_group, NULL,
-                               LTTNG_KERNEL_ABI_TRACEPOINT);
+                       event_notifier = _lttng_event_notifier_create(event_notifier_enabler, desc);
                        if (IS_ERR(event_notifier)) {
                                printk(KERN_INFO "Unable to create event_notifier %s\n",
                                        probe_desc->event_desc[i]->event_name);
@@ -2545,8 +2539,9 @@ void lttng_event_enabler_destroy(struct lttng_event_enabler_common *event_enable
                struct lttng_event_notifier_enabler *event_notifier_enabler =
                        container_of(event_enabler, struct lttng_event_notifier_enabler, parent);
 
-               list_del(&event_notifier_enabler->node);
                lttng_enabler_destroy(event_enabler);
+               if (event_notifier_enabler->published)
+                       list_del(&event_notifier_enabler->node);
                kfree(event_notifier_enabler);
                break;
        }
@@ -2556,9 +2551,9 @@ void lttng_event_enabler_destroy(struct lttng_event_enabler_common *event_enable
 }
 
 struct lttng_event_notifier_enabler *lttng_event_notifier_enabler_create(
-               struct lttng_event_notifier_group *event_notifier_group,
                enum lttng_enabler_format_type format_type,
-               struct lttng_kernel_abi_event_notifier *event_notifier_param)
+               struct lttng_kernel_abi_event_notifier *event_notifier_param,
+               struct lttng_event_notifier_group *event_notifier_group)
 {
        struct lttng_event_notifier_enabler *event_notifier_enabler;
 
@@ -2580,14 +2575,17 @@ struct lttng_event_notifier_enabler *lttng_event_notifier_enabler_create(
        event_notifier_enabler->parent.enabled = 0;
        event_notifier_enabler->parent.user_token = event_notifier_param->event.token;
        event_notifier_enabler->group = event_notifier_group;
+       return event_notifier_enabler;
+}
 
+void lttng_event_notifier_enabler_group_add(struct lttng_event_notifier_group *event_notifier_group,
+               struct lttng_event_notifier_enabler *event_notifier_enabler)
+{
        mutex_lock(&sessions_mutex);
        list_add(&event_notifier_enabler->node, &event_notifier_enabler->group->enablers_head);
+       event_notifier_enabler->published = true;
        lttng_event_notifier_group_sync_enablers(event_notifier_enabler->group);
-
        mutex_unlock(&sessions_mutex);
-
-       return event_notifier_enabler;
 }
 
 int lttng_event_notifier_enabler_enable(
This page took 0.04514 seconds and 4 git commands to generate.