* Copyright (C) 2020 Francis Deslauriers <francis.deslauriers@efficios.com>
*/
+#include <asm/barrier.h>
#include <linux/bug.h>
#include <lttng/lttng-bytecode.h>
#include <lttng/event-notifier-notification.h>
#include <lttng/events-internal.h>
#include <lttng/probe-user.h>
-#include <wrapper/barrier.h>
/*
* The capture buffer size needs to be below 1024 bytes to avoid the
break;
default:
WARN_ON_ONCE(1);
+ ret = -1;
+ goto end;
}
ret = lttng_msgpack_end_map(writer);
}
static
-int64_t capture_sequence_element_signed(uint8_t *ptr,
- const struct lttng_kernel_type_integer *type)
+int capture_sequence_element_signed(uint8_t *ptr,
+ const struct lttng_kernel_type_integer *type,
+ int64_t *_value)
{
int64_t value = 0;
unsigned int size = type->size;
if (user) {
if (lttng_copy_from_user_check_nofault(&tmp, ptr, sizeof(int8_t)))
- tmp = 0;
+ return -1;
} else {
tmp = *ptr;
}
if (user) {
if (lttng_copy_from_user_check_nofault(&tmp, ptr, sizeof(int16_t)))
- tmp = 0;
+ return -1;
} else {
tmp = *(int16_t *) ptr;
}
if (user) {
if (lttng_copy_from_user_check_nofault(&tmp, ptr, sizeof(int32_t)))
- tmp = 0;
+ return -1;
} else {
tmp = *(int32_t *) ptr;
}
if (user) {
if (lttng_copy_from_user_check_nofault(&tmp, ptr, sizeof(int64_t)))
- tmp = 0;
+ return -1;
} else {
tmp = *(int64_t *) ptr;
}
}
default:
WARN_ON_ONCE(1);
+ return -1;
}
- return value;
+ *_value = value;
+ return 0;
}
static
-uint64_t capture_sequence_element_unsigned(uint8_t *ptr,
- const struct lttng_kernel_type_integer *type)
+int capture_sequence_element_unsigned(uint8_t *ptr,
+ const struct lttng_kernel_type_integer *type,
+ uint64_t *_value)
{
uint64_t value = 0;
unsigned int size = type->size;
if (user) {
if (lttng_copy_from_user_check_nofault(&tmp, ptr, sizeof(uint8_t)))
- tmp = 0;
+ return -1;
} else {
tmp = *ptr;
}
if (user) {
if (lttng_copy_from_user_check_nofault(&tmp, ptr, sizeof(uint16_t)))
- tmp = 0;
+ return -1;
} else {
tmp = *(uint16_t *) ptr;
}
if (user) {
if (lttng_copy_from_user_check_nofault(&tmp, ptr, sizeof(uint32_t)))
- tmp = 0;
+ return -1;
} else {
tmp = *(uint32_t *) ptr;
}
if (user) {
if (lttng_copy_from_user_check_nofault(&tmp, ptr, sizeof(uint64_t)))
- tmp = 0;
+ return -1;
} else {
tmp = *(uint64_t *) ptr;
}
}
default:
WARN_ON_ONCE(1);
+ return -1;
}
- return value;
+ *_value = value;
+ return 0;
}
int capture_sequence(struct lttng_msgpack_writer *writer,
signedness = integer_type->signedness;
for (i = 0; i < output->u.sequence.nr_elem; i++) {
if (signedness) {
- ret = lttng_msgpack_write_signed_integer(writer,
- capture_sequence_element_signed(ptr, integer_type));
+ int64_t v;
+
+ ret = capture_sequence_element_signed(ptr, integer_type, &v);
+ if (ret) {
+ goto end;
+ }
+ ret = lttng_msgpack_write_signed_integer(writer, v);
if (ret) {
goto end;
}
} else {
- ret = lttng_msgpack_write_unsigned_integer(writer,
- capture_sequence_element_unsigned(ptr, integer_type));
+ uint64_t v;
+
+ ret = capture_sequence_element_unsigned(ptr, integer_type, &v);
+ if (ret) {
+ goto end;
+ }
+ ret = lttng_msgpack_write_unsigned_integer(writer, v);
if (ret) {
goto end;
}
int ret;
/*
- * lttng_smp_load_acquire paired with lttng_smp_store_release orders
- * creation of the error counter and setting error_counter_len
- * before the error_counter is used.
+ * smp_load_acquire paired with smp_store_release orders creation of
+ * the error counter and setting error_counter_len before the
+ * error_counter is used.
*/
- error_counter = lttng_smp_load_acquire(&event_notifier_group->error_counter);
+ error_counter = smp_load_acquire(&event_notifier_group->error_counter);
/* This group may not have an error counter attached to it. */
if (!error_counter)
return;