projects
/
lttng-tools.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
| inline |
side by side
Misleading error handling: utils_create_pid_file() should return 0 on success
[lttng-tools.git]
/
src
/
common
/
utils.c
diff --git
a/src/common/utils.c
b/src/common/utils.c
index e7dccb7b7490cb1c1392461304e70ea7cbf5d390..3428d312d6ee8a2c562936284bf86690229be56f 100644
(file)
--- a/
src/common/utils.c
+++ b/
src/common/utils.c
@@
-477,10
+477,14
@@
int utils_create_pid_file(pid_t pid, const char *filepath)
ret = fprintf(fp, "%d\n", pid);
if (ret < 0) {
PERROR("fprintf pid file");
+ goto error;
}
- fclose(fp);
+ if (fclose(fp)) {
+ PERROR("fclose");
+ }
DBG("Pid %d written in file %s", pid, filepath);
+ ret = 0;
error:
return ret;
}
This page took
0.023871 seconds
and
4
git commands to generate.