clang-tidy: add Chrome-inspired checks

[lttng-tools.git] / src / common / file-descriptor.hpp

diff --git a/src/common/file-descriptor.hpp b/src/common/file-descriptor.hpp
index 6354a12e2f96f5007ab67cd6cf4d98c004f546f9..54c2e182a1bb352e5395990ae486be093d5ef4e9 100644 (file)
--- a/src/common/file-descriptor.hpp
+++ b/src/common/file-descriptor.hpp
@@ -27,8 +27,7 @@ public:
 
        file_descriptor(const file_descriptor&) = delete;
 
-       file_descriptor(file_descriptor&& other) : _raw_fd{-1}
-       {
+       file_descriptor(file_descriptor&& other) noexcept {
                LTTNG_ASSERT(_is_valid_fd(_raw_fd));
                std::swap(_raw_fd, other._raw_fd);
        }
@@ -41,10 +40,7 @@ public:
 
                const auto ret = ::close(_raw_fd);
                if (ret) {
-                       PERROR("%s",
-                                       fmt::format("Failed to close file descriptor: fd = {}",
-                                                       _raw_fd)
-                                                       .c_str());
+                       PERROR("Failed to close file descriptor: fd=%i", _raw_fd);
                }
        }
 
@@ -60,7 +56,7 @@ private:
                return fd >= 0;
        }
 
-       int _raw_fd;
+       int _raw_fd = -1;
 };
 
-} /* namespace lttng */
\ No newline at end of file
+} /* namespace lttng */