file-desrcriptor: add assignment operator

[lttng-tools.git] / src / common / file-descriptor.hpp

diff --git a/src/common/file-descriptor.hpp b/src/common/file-descriptor.hpp
index 6354a12e2f96f5007ab67cd6cf4d98c004f546f9..0ddc2b91c8f30a8d689a5be1b9fe26b8b0b412b9 100644 (file)
--- a/src/common/file-descriptor.hpp
+++ b/src/common/file-descriptor.hpp
@@ -16,36 +16,36 @@ namespace lttng {
 
 /*
  * RAII wrapper around a UNIX file descriptor. A file_descriptor's underlying
- * file descriptor
+ * file descriptor.
  */
 class file_descriptor {
 public:
-       explicit file_descriptor(int raw_fd) noexcept : _raw_fd{raw_fd}
+       file_descriptor()
+       {
+       }
+
+       explicit file_descriptor(int raw_fd) noexcept : _raw_fd{ raw_fd }
        {
                LTTNG_ASSERT(_is_valid_fd(_raw_fd));
        }
 
        file_descriptor(const file_descriptor&) = delete;
+       file_descriptor& operator=(const file_descriptor&) = delete;
+       file_descriptor& operator=(file_descriptor&& other)
+       {
+               _cleanup();
+               std::swap(_raw_fd, other._raw_fd);
+               return *this;
+       }
 
-       file_descriptor(file_descriptor&& other) : _raw_fd{-1}
+       file_descriptor(file_descriptor&& other) noexcept
        {
-               LTTNG_ASSERT(_is_valid_fd(_raw_fd));
                std::swap(_raw_fd, other._raw_fd);
        }
 
        ~file_descriptor()
        {
-               if (!_is_valid_fd(_raw_fd)) {
-                       return;
-               }
-
-               const auto ret = ::close(_raw_fd);
-               if (ret) {
-                       PERROR("%s",
-                                       fmt::format("Failed to close file descriptor: fd = {}",
-                                                       _raw_fd)
-                                                       .c_str());
-               }
+               _cleanup();
        }
 
        int fd() const noexcept
@@ -60,7 +60,21 @@ private:
                return fd >= 0;
        }
 
-       int _raw_fd;
+       void _cleanup()
+       {
+               if (!_is_valid_fd(_raw_fd)) {
+                       return;
+               }
+
+               const auto ret = ::close(_raw_fd);
+
+               _raw_fd = -1;
+               if (ret) {
+                       PERROR("Failed to close file descriptor: fd=%i", _raw_fd);
+               }
+       }
+
+       int _raw_fd = -1;
 };
 
-} /* namespace lttng */
\ No newline at end of file
+} /* namespace lttng */