clang-tidy: add most bugprone warnings

[lttng-tools.git] / src / bin / lttng-sessiond / ust-registry-channel.hpp

diff --git a/src/bin/lttng-sessiond/ust-registry-channel.hpp b/src/bin/lttng-sessiond/ust-registry-channel.hpp
index e8819812e139aa28062f86dfb9202241cc81f8b5..cbe1ab5af48fd4e9153dca746dcdff4dcc980d51 100644 (file)
--- a/src/bin/lttng-sessiond/ust-registry-channel.hpp
+++ b/src/bin/lttng-sessiond/ust-registry-channel.hpp
@@ -9,6 +9,7 @@
 #define LTTNG_UST_REGISTRY_CHANNEL_H
 
 #include "stream-class.hpp"
+#include "trace-class.hpp"
 
 #include <common/hashtable/hashtable.hpp>
 
@@ -31,6 +32,8 @@ public:
        using event_added_listener_fn = std::function<void(const registry_channel&, const registry_event &)>;
 
        registry_channel(uint32_t channel_id,
+                       const lttng::sessiond::trace::abi& trace_abi,
+                       std::string default_clock_class_name,
                        registered_listener_fn channel_registered_listener,
                        event_added_listener_fn new_event_listener);
        void add_event(int session_objd,
@@ -43,10 +46,10 @@ public:
                        lttng_buffer_type buffer_type,
                        const ust_app& app,
                        uint32_t& out_event_id);
-       virtual ~registry_channel();
+       ~registry_channel() override;
 
-       virtual const lttng::sessiond::trace::type& get_context() const override final;
-       void set_context(lttng::sessiond::trace::type::cuptr context);
+       const lttng::sessiond::trace::type *event_context() const final;
+       void event_context(lttng::sessiond::trace::type::cuptr context);
 
        /* Channel was registered to at least one application. */
        bool is_registered() const;
@@ -55,12 +58,6 @@ public:
        uint64_t _key;
        uint64_t _consumer_key;
 
-       /*
-        * Flag for this channel if the metadata was dumped once during
-        * registration. 0 means no, 1 yes.
-        */
-       unsigned int _metadata_dumped;
-
        /*
         * Hash table containing events sent by the UST tracer. MUST be accessed
         * with a RCU read side lock acquired.
@@ -73,8 +70,8 @@ public:
        uint32_t _next_event_id;
 
 private:
-       virtual void _accept_on_event_classes(
-                       lttng::sessiond::trace::trace_class_visitor& trace_class_visitor) const override final;
+       void _accept_on_event_classes(
+                       lttng::sessiond::trace::trace_class_visitor& trace_class_visitor) const final;
 
        registered_listener_fn _is_registered_listener;
        event_added_listener_fn _event_added_listener;