Fix: missing RCU read side critical sections

[lttng-tools.git] / src / bin / lttng-sessiond / action-executor.cpp

diff --git a/src/bin/lttng-sessiond/action-executor.cpp b/src/bin/lttng-sessiond/action-executor.cpp
index 032ac11a08de74d0f0657b67086e2bfc7afc99c4..34d3b7130f0a713b089bff4461cab34c9ce36445 100644 (file)
--- a/src/bin/lttng-sessiond/action-executor.cpp
+++ b/src/bin/lttng-sessiond/action-executor.cpp
@@ -309,6 +309,7 @@ static int action_executor_start_session_handler(
        }
 
        session_lock_list();
+       rcu_read_lock();
        session = session_find_by_id(LTTNG_OPTIONAL_GET(item->context.session_id));
        if (!session) {
                DBG("Failed to find session `%s` by name while executing `%s` action of trigger `%s`",
@@ -353,6 +354,7 @@ error_unlock_session:
        session_unlock(session);
        session_put(session);
 error_unlock_list:
+       rcu_read_unlock();
        session_unlock_list();
 end:
        return ret;
@@ -392,6 +394,7 @@ static int action_executor_stop_session_handler(
        }
 
        session_lock_list();
+       rcu_read_lock();
        session = session_find_by_id(LTTNG_OPTIONAL_GET(item->context.session_id));
        if (!session) {
                DBG("Failed to find session `%s` by name while executing `%s` action of trigger `%s`",
@@ -436,6 +439,7 @@ error_unlock_session:
        session_unlock(session);
        session_put(session);
 error_unlock_list:
+       rcu_read_unlock();
        session_unlock_list();
 end:
        return ret;
@@ -475,6 +479,7 @@ static int action_executor_rotate_session_handler(
        }
 
        session_lock_list();
+       rcu_read_lock();
        session = session_find_by_id(LTTNG_OPTIONAL_GET(item->context.session_id));
        if (!session) {
                DBG("Failed to find session `%s` by name while executing `%s` action of trigger `%s`",
@@ -526,6 +531,7 @@ error_unlock_session:
        session_unlock(session);
        session_put(session);
 error_unlock_list:
+       rcu_read_unlock();
        session_unlock_list();
 end:
        return ret;
@@ -580,6 +586,7 @@ static int action_executor_snapshot_session_handler(
        }
 
        session_lock_list();
+       rcu_read_lock();
        session = session_find_by_id(LTTNG_OPTIONAL_GET(item->context.session_id));
        if (!session) {
                DBG("Failed to find session `%s` by name while executing `%s` action of trigger `%s`",
@@ -620,6 +627,7 @@ error_unlock_session:
        session_unlock(session);
        session_put(session);
 error_unlock_list:
+       rcu_read_unlock();
        session_unlock_list();
 end:
        return ret;
@@ -872,6 +880,7 @@ enum action_executor_status action_executor_enqueue_trigger(
        bool signal = false;
 
        LTTNG_ASSERT(trigger);
+       ASSERT_RCU_READ_LOCKED();
 
        pthread_mutex_lock(&executor->work.lock);
        /* Check for queue overflow. */