*/
static int warn_userspace_probe_syntax(const char *symbol)
{
- unsigned long addr = 0;
- size_t offset = 0;
int ret;
/* Check if the symbol field is an hex address. */
- ret = sscanf(symbol, "0x%lx", &addr);
+ ret = sscanf(symbol, "0x%*x");
if (ret > 0) {
/* If there is a match, print a warning and return an error. */
ERR("Userspace probe on address not supported yet.");
}
/* Check if the symbol field is an decimal address. */
- ret = sscanf(symbol, "%lu", &addr);
+ ret = sscanf(symbol, "%*u");
if (ret > 0) {
/* If there is a match, print a warning and return an error. */
ERR("Userspace probe on address not supported yet.");
}
/* Check if the symbol field is symbol+hex_offset. */
- ret = sscanf(symbol, "%*[^+]+0x%lx", &offset);
+ ret = sscanf(symbol, "%*[^+]+0x%*x");
if (ret > 0) {
/* If there is a match, print a warning and return an error. */
ERR("Userspace probe on symbol+offset not supported yet.");
}
/* Check if the symbol field is symbol+decimal_offset. */
- ret = sscanf(symbol, "%*[^+]+%lu", &offset);
+ ret = sscanf(symbol, "%*[^+]+%*u");
if (ret > 0) {
/* If there is a match, print a warning and return an error. */
ERR("Userspace probe on symbol+offset not supported yet.");
lookup_method =
lttng_userspace_probe_location_lookup_method_tracepoint_sdt_create();
if (!lookup_method) {
- WARN("Failed to create ELF lookup method");
+ WARN("Failed to create SDT lookup method");
ret = CMD_ERROR;
goto end_string;
}
}
/*
- * Check if the file exists using access(2). If it does not, walk the
- * $PATH.
+ * Check if the file exists using access(2), If it does not,
+ * return an error.
*/
ret = access(real_target_path, F_OK);
if (ret) {
+ ERR("Cannot find binary at path: %s.", real_target_path);
ret = CMD_ERROR;
goto end_destroy_lookup_method;
}
{
int length = 0;
int i;
- const char *preamble = " excluding ";
+ const char preamble[] = " excluding ";
char *ret;
int count = names ? strutils_array_of_strings_len(names) : 0;
length += strlen(names[i]) + 4;
}
- /* add length of preamble + one for NUL - one for last (missing) comma */
- length += strlen(preamble);
- ret = zmalloc(length + 1);
+ length += sizeof(preamble);
+ ret = zmalloc(length);
if (!ret) {
return NULL;
}