int nr_probes = 0;
struct tracepoint_probe *old, *new;
- WARN_ON(!probe);
-
+ if (!probe) {
+ WARN_ON(1);
+ return ERR_PTR(-EINVAL);
+ }
debug_print_probes(entry);
old = entry->probes;
if (old) {
debug_print_probes(entry);
/* (N -> M), (N > 1, M >= 0) probes */
- for (nr_probes = 0; old[nr_probes].func; nr_probes++) {
- if (!probe ||
- (old[nr_probes].func == probe &&
- old[nr_probes].data == data))
- nr_del++;
+ if (probe) {
+ for (nr_probes = 0; old[nr_probes].func; nr_probes++) {
+ if (old[nr_probes].func == probe &&
+ old[nr_probes].data == data)
+ nr_del++;
+ }
}
if (nr_probes - nr_del == 0) {
if (new == NULL)
return ERR_PTR(-ENOMEM);
for (i = 0; old[i].func; i++)
- if (probe &&
- (old[i].func != probe || old[i].data != data))
+ if (old[i].func != probe || old[i].data != data)
new[j++] = old[i];
new[nr_probes - nr_del].func = NULL;
entry->refcount = nr_probes - nr_del;
}
}
-static void lib_update_tracepoints(void)
+static void lib_update_tracepoints(struct tracepoint_lib *lib)
{
- struct tracepoint_lib *lib;
-
- cds_list_for_each_entry(lib, &libs, list) {
- tracepoint_update_probe_range(lib->tracepoints_start,
- lib->tracepoints_start + lib->tracepoints_count);
- }
+ tracepoint_update_probe_range(lib->tracepoints_start,
+ lib->tracepoints_start + lib->tracepoints_count);
}
/*
*/
static void tracepoint_update_probes(void)
{
+ struct tracepoint_lib *lib;
+
/* tracepoints registered from libraries and executable. */
- lib_update_tracepoints();
+ cds_list_for_each_entry(lib, &libs, list)
+ lib_update_tracepoints(lib);
}
static struct tracepoint_probe *
lib_added:
new_tracepoints(tracepoints_start, tracepoints_start + tracepoints_count);
- /* TODO: update just the loaded lib */
- lib_update_tracepoints();
+ lib_update_tracepoints(pl);
pthread_mutex_unlock(&tracepoint_mutex);
DBG("just registered a tracepoints section from %p and having %d tracepoints",