projects
/
lttng-tools.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Remove MSG_WAITALL on every recvmsg() socket type
[lttng-tools.git]
/
src
/
common
/
sessiond-comm
/
inet6.c
diff --git
a/src/common/sessiond-comm/inet6.c
b/src/common/sessiond-comm/inet6.c
index 0d96c31c21c98eca65812feeb2e31c91fa6b60d6..ddbb50ed43aa96dc94b6f2fe4b8201c4925b8c5c 100644
(file)
--- a/
src/common/sessiond-comm/inet6.c
+++ b/
src/common/sessiond-comm/inet6.c
@@
-47,12
+47,13
@@
static const struct lttcomm_proto_ops inet6_ops = {
/*
* Creates an PF_INET socket.
*/
/*
* Creates an PF_INET socket.
*/
+__attribute__((visibility("hidden")))
int lttcomm_create_inet6_sock(struct lttcomm_sock *sock, int type, int proto)
{
int val = 1, ret;
/* Create server socket */
int lttcomm_create_inet6_sock(struct lttcomm_sock *sock, int type, int proto)
{
int val = 1, ret;
/* Create server socket */
- if ((sock->fd = socket(PF_INET, type, proto)) < 0) {
+ if ((sock->fd = socket(PF_INET
6
, type, proto)) < 0) {
PERROR("socket inet6");
goto error;
}
PERROR("socket inet6");
goto error;
}
@@
-77,6
+78,7
@@
error:
/*
* Bind socket and return.
*/
/*
* Bind socket and return.
*/
+__attribute__((visibility("hidden")))
int lttcomm_bind_inet6_sock(struct lttcomm_sock *sock)
{
int ret;
int lttcomm_bind_inet6_sock(struct lttcomm_sock *sock)
{
int ret;
@@
-93,6
+95,7
@@
int lttcomm_bind_inet6_sock(struct lttcomm_sock *sock)
/*
* Connect PF_INET socket.
*/
/*
* Connect PF_INET socket.
*/
+__attribute__((visibility("hidden")))
int lttcomm_connect_inet6_sock(struct lttcomm_sock *sock)
{
int ret, closeret;
int lttcomm_connect_inet6_sock(struct lttcomm_sock *sock)
{
int ret, closeret;
@@
-122,10
+125,11
@@
error_connect:
* Do an accept(2) on the sock and return the new lttcomm socket. The socket
* MUST be bind(2) before.
*/
* Do an accept(2) on the sock and return the new lttcomm socket. The socket
* MUST be bind(2) before.
*/
+__attribute__((visibility("hidden")))
struct lttcomm_sock *lttcomm_accept_inet6_sock(struct lttcomm_sock *sock)
{
int new_fd;
struct lttcomm_sock *lttcomm_accept_inet6_sock(struct lttcomm_sock *sock)
{
int new_fd;
- socklen_t len
= 0
;
+ socklen_t len;
struct lttcomm_sock *new_sock;
if (sock->proto == LTTCOMM_SOCK_UDP) {
struct lttcomm_sock *new_sock;
if (sock->proto == LTTCOMM_SOCK_UDP) {
@@
-141,6
+145,8
@@
struct lttcomm_sock *lttcomm_accept_inet6_sock(struct lttcomm_sock *sock)
goto error;
}
goto error;
}
+ len = sizeof(new_sock->sockaddr.addr.sin6);
+
/* Blocking call */
new_fd = accept(sock->fd,
(struct sockaddr *) &new_sock->sockaddr.addr.sin6, &len);
/* Blocking call */
new_fd = accept(sock->fd,
(struct sockaddr *) &new_sock->sockaddr.addr.sin6, &len);
@@
-163,6
+169,7
@@
error:
/*
* Make the socket listen using LTTNG_SESSIOND_COMM_MAX_LISTEN.
*/
/*
* Make the socket listen using LTTNG_SESSIOND_COMM_MAX_LISTEN.
*/
+__attribute__((visibility("hidden")))
int lttcomm_listen_inet6_sock(struct lttcomm_sock *sock, int backlog)
{
int ret;
int lttcomm_listen_inet6_sock(struct lttcomm_sock *sock, int backlog)
{
int ret;
@@
-193,12
+200,14
@@
end:
*
* Return the size of received data.
*/
*
* Return the size of received data.
*/
+__attribute__((visibility("hidden")))
ssize_t lttcomm_recvmsg_inet6_sock(struct lttcomm_sock *sock, void *buf,
size_t len, int flags)
{
struct msghdr msg;
struct iovec iov[1];
ssize_t ret = -1;
ssize_t lttcomm_recvmsg_inet6_sock(struct lttcomm_sock *sock, void *buf,
size_t len, int flags)
{
struct msghdr msg;
struct iovec iov[1];
ssize_t ret = -1;
+ size_t len_last;
memset(&msg, 0, sizeof(msg));
memset(&msg, 0, sizeof(msg));
@@
-210,16
+219,21
@@
ssize_t lttcomm_recvmsg_inet6_sock(struct lttcomm_sock *sock, void *buf,
msg.msg_name = (struct sockaddr *) &sock->sockaddr.addr.sin6;
msg.msg_namelen = sizeof(sock->sockaddr.addr.sin6);
msg.msg_name = (struct sockaddr *) &sock->sockaddr.addr.sin6;
msg.msg_namelen = sizeof(sock->sockaddr.addr.sin6);
- if (flags == 0) {
- flags = MSG_WAITALL;
- }
-
do {
do {
+ len_last = iov[0].iov_len;
ret = recvmsg(sock->fd, &msg, flags);
ret = recvmsg(sock->fd, &msg, flags);
- } while (ret < 0 && errno == EINTR);
+ if (ret > 0) {
+ iov[0].iov_base += ret;
+ iov[0].iov_len -= ret;
+ assert(ret <= len_last);
+ }
+ } while ((ret > 0 && ret < len_last) || (ret < 0 && errno == EINTR));
if (ret < 0) {
if (ret < 0) {
- PERROR("recvmsg inet6");
+ PERROR("recvmsg inet");
+ } else if (ret > 0) {
+ ret = len;
}
}
+ /* Else ret = 0 meaning an orderly shutdown. */
return ret;
}
return ret;
}
@@
-229,6
+243,7
@@
ssize_t lttcomm_recvmsg_inet6_sock(struct lttcomm_sock *sock, void *buf,
*
* Return the size of sent data.
*/
*
* Return the size of sent data.
*/
+__attribute__((visibility("hidden")))
ssize_t lttcomm_sendmsg_inet6_sock(struct lttcomm_sock *sock, void *buf,
size_t len, int flags)
{
ssize_t lttcomm_sendmsg_inet6_sock(struct lttcomm_sock *sock, void *buf,
size_t len, int flags)
{
@@
-271,6
+286,7
@@
ssize_t lttcomm_sendmsg_inet6_sock(struct lttcomm_sock *sock, void *buf,
/*
* Shutdown cleanly and close.
*/
/*
* Shutdown cleanly and close.
*/
+__attribute__((visibility("hidden")))
int lttcomm_close_inet6_sock(struct lttcomm_sock *sock)
{
int ret;
int lttcomm_close_inet6_sock(struct lttcomm_sock *sock)
{
int ret;
This page took
0.025838 seconds
and
4
git commands to generate.