projects
/
lttng-tools.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fix: lttng: add-trigger: leak of source argument
[lttng-tools.git]
/
src
/
common
/
actions
/
action.c
diff --git
a/src/common/actions/action.c
b/src/common/actions/action.c
index 86628542bc50186c32b20a0bc026530a235672d6..95a0c0f4d20a19eb743b60d392c65934a82d656f 100644
(file)
--- a/
src/common/actions/action.c
+++ b/
src/common/actions/action.c
@@
-140,15
+140,24
@@
ssize_t lttng_action_create_from_payload(struct lttng_payload_view *view,
struct lttng_action **action)
{
ssize_t consumed_len, specific_action_consumed_len;
struct lttng_action **action)
{
ssize_t consumed_len, specific_action_consumed_len;
- const struct lttng_action_comm *action_comm;
action_create_from_payload_cb create_from_payload_cb;
action_create_from_payload_cb create_from_payload_cb;
+ const struct lttng_action_comm *action_comm;
+ const struct lttng_payload_view action_comm_view =
+ lttng_payload_view_from_view(
+ view, 0, sizeof(*action_comm));
if (!view || !action) {
consumed_len = -1;
goto end;
}
if (!view || !action) {
consumed_len = -1;
goto end;
}
- action_comm = (const struct lttng_action_comm *) view->buffer.data;
+ if (!lttng_payload_view_is_valid(&action_comm_view)) {
+ /* Payload not large enough to contain the header. */
+ consumed_len = -1;
+ goto end;
+ }
+
+ action_comm = (const struct lttng_action_comm *) action_comm_view.buffer.data;
DBG("Create action from payload: action-type=%s",
lttng_action_type_string(action_comm->action_type));
DBG("Create action from payload: action-type=%s",
lttng_action_type_string(action_comm->action_type));
This page took
0.024733 seconds
and
4
git commands to generate.