projects
/
lttng-tools.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fix: session name max length was not handled correctly
[lttng-tools.git]
/
src
/
bin
/
lttng
/
conf.c
diff --git
a/src/bin/lttng/conf.c
b/src/bin/lttng/conf.c
index 995407d03d4d4ba6863ee991c6da927df06e8db8..b6632fcb144c052fa0ef4a9652843a074abd64c7 100644
(file)
--- a/
src/bin/lttng/conf.c
+++ b/
src/bin/lttng/conf.c
@@
-40,6
+40,7
@@
char *config_get_file_path(char *path)
ret = asprintf(&file_path, "%s/%s", path, CONFIG_FILENAME);
if (ret < 0) {
ERR("Fail allocating config file path");
ret = asprintf(&file_path, "%s/%s", path, CONFIG_FILENAME);
if (ret < 0) {
ERR("Fail allocating config file path");
+ file_path = NULL;
}
return file_path;
}
return file_path;
@@
-65,9
+66,7
@@
static FILE *open_config(char *path, const char *mode)
}
error:
}
error:
- if (file_path) {
- free(file_path);
- }
+ free(file_path);
return fp;
}
return fp;
}
@@
-205,6
+204,7
@@
char *config_read_session_name(char *path)
if (fp == NULL) {
ERR("Can't find valid lttng config %s/.lttngrc", path);
MSG("Did you create a session? (lttng create <my_session>)");
if (fp == NULL) {
ERR("Can't find valid lttng config %s/.lttngrc", path);
MSG("Did you create a session? (lttng create <my_session>)");
+ free(session_name);
goto error;
}
goto error;
}
@@
-223,6
+223,7
@@
char *config_read_session_name(char *path)
}
error_close:
}
error_close:
+ free(session_name);
ret = fclose(fp);
if (ret < 0) {
PERROR("close config read session name");
ret = fclose(fp);
if (ret < 0) {
PERROR("close config read session name");
@@
-248,14
+249,16
@@
found:
int config_add_session_name(char *path, char *name)
{
int ret;
int config_add_session_name(char *path, char *name)
{
int ret;
- char session_name[NAME_MAX];
+ char *attr = "session=";
+ /* Max name len accepted plus attribute's len and the NULL byte. */
+ char session_name[NAME_MAX + strlen(attr) + 1];
/*
* With GNU C < 2.1, snprintf returns -1 if the target buffer is too small;
* With GNU C >= 2.1, snprintf returns the required size (excluding closing null)
*/
/*
* With GNU C < 2.1, snprintf returns -1 if the target buffer is too small;
* With GNU C >= 2.1, snprintf returns the required size (excluding closing null)
*/
- ret = snprintf(session_name,
NAME_MAX, "session=%s\n"
, name);
- if (
(ret < 0) || (ret >= NAME_MAX)
) {
+ ret = snprintf(session_name,
sizeof(session_name), "%s%s\n", attr
, name);
+ if (
ret < 0
) {
ret = -1;
goto error;
}
ret = -1;
goto error;
}
This page took
0.024984 seconds
and
4
git commands to generate.