projects
/
lttng-tools.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Create all trace directories and files with client user credentials
[lttng-tools.git]
/
lttng-sessiond
/
ust-consumer.c
diff --git
a/lttng-sessiond/ust-consumer.c
b/lttng-sessiond/ust-consumer.c
index df569368ae04f2e8faafb1b9ebbfde069fc618aa..b87d61120faa2473f7d42a9609a432e31bc7bebf 100644
(file)
--- a/
lttng-sessiond/ust-consumer.c
+++ b/
lttng-sessiond/ust-consumer.c
@@
-34,7
+34,8
@@
* Send all stream fds of UST channel to the consumer.
*/
static int send_channel_streams(int sock,
* Send all stream fds of UST channel to the consumer.
*/
static int send_channel_streams(int sock,
- struct ust_app_channel *uchan)
+ struct ust_app_channel *uchan,
+ uid_t uid, gid_t gid)
{
int ret, fd;
struct lttcomm_consumer_msg lum;
{
int ret, fd;
struct lttcomm_consumer_msg lum;
@@
-46,8
+47,11
@@
static int send_channel_streams(int sock,
lum.cmd_type = LTTNG_CONSUMER_ADD_CHANNEL;
/*
lum.cmd_type = LTTNG_CONSUMER_ADD_CHANNEL;
/*
- * We need to keep shm_fd open to make sure this key stays unique within
- * the session daemon.
+ * We need to keep shm_fd open while we transfer the stream file
+ * descriptors to make sure this key stays unique within the
+ * session daemon. We can free the channel shm_fd without
+ * problem after we finished sending stream fds for that
+ * channel.
*/
lum.u.channel.channel_key = uchan->obj->shm_fd;
lum.u.channel.max_sb_size = uchan->attr.subbuf_size;
*/
lum.u.channel.channel_key = uchan->obj->shm_fd;
lum.u.channel.max_sb_size = uchan->attr.subbuf_size;
@@
-81,6
+85,8
@@
static int send_channel_streams(int sock,
*/
lum.u.stream.output = DEFAULT_UST_CHANNEL_OUTPUT;
lum.u.stream.mmap_len = stream->obj->memory_map_size;
*/
lum.u.stream.output = DEFAULT_UST_CHANNEL_OUTPUT;
lum.u.stream.mmap_len = stream->obj->memory_map_size;
+ lum.u.stream.uid = uid;
+ lum.u.stream.gid = gid;
strncpy(lum.u.stream.path_name, stream->pathname, PATH_MAX - 1);
lum.u.stream.path_name[PATH_MAX - 1] = '\0';
DBG("Sending stream %d to consumer", lum.u.stream.stream_key);
strncpy(lum.u.stream.path_name, stream->pathname, PATH_MAX - 1);
lum.u.stream.path_name[PATH_MAX - 1] = '\0';
DBG("Sending stream %d to consumer", lum.u.stream.stream_key);
@@
-97,18
+103,7
@@
static int send_channel_streams(int sock,
perror("send consumer stream ancillary data");
goto error;
}
perror("send consumer stream ancillary data");
goto error;
}
-
- /*
- * We release the stream object here, as we have passed
- * it to the consumer.
- */
- /* Ensure we don't let the app know (sock = -1). */
- ustctl_release_object(-1, stream->obj);
- cds_list_del(&stream->list);
- free(stream);
}
}
- /* Ensure we don't let the app know (sock = -1). */
- ustctl_release_object(-1, uchan->obj);
DBG("consumer channel streams sent");
DBG("consumer channel streams sent");
@@
-132,6
+127,11
@@
int ust_consumer_send_session(int consumer_fd, struct ust_app_session *usess)
DBG("Sending metadata stream fd");
DBG("Sending metadata stream fd");
+ if (consumer_fd < 0) {
+ ERR("Consumer has negative file descriptor");
+ return -EINVAL;
+ }
+
if (usess->metadata->obj->shm_fd != 0) {
int fd;
int fds[2];
if (usess->metadata->obj->shm_fd != 0) {
int fd;
int fds[2];
@@
-161,6
+161,8
@@
int ust_consumer_send_session(int consumer_fd, struct ust_app_session *usess)
lum.u.stream.state = LTTNG_CONSUMER_ACTIVE_STREAM;
lum.u.stream.output = DEFAULT_UST_CHANNEL_OUTPUT;
lum.u.stream.mmap_len = usess->metadata->stream_obj->memory_map_size;
lum.u.stream.state = LTTNG_CONSUMER_ACTIVE_STREAM;
lum.u.stream.output = DEFAULT_UST_CHANNEL_OUTPUT;
lum.u.stream.mmap_len = usess->metadata->stream_obj->memory_map_size;
+ lum.u.stream.uid = usess->uid;
+ lum.u.stream.gid = usess->gid;
strncpy(lum.u.stream.path_name, usess->metadata->pathname, PATH_MAX - 1);
lum.u.stream.path_name[PATH_MAX - 1] = '\0';
DBG("Sending metadata stream %d to consumer", lum.u.stream.stream_key);
strncpy(lum.u.stream.path_name, usess->metadata->pathname, PATH_MAX - 1);
lum.u.stream.path_name[PATH_MAX - 1] = '\0';
DBG("Sending metadata stream %d to consumer", lum.u.stream.stream_key);
@@
-176,10
+178,6
@@
int ust_consumer_send_session(int consumer_fd, struct ust_app_session *usess)
perror("send consumer stream");
goto error;
}
perror("send consumer stream");
goto error;
}
- /* Metadata fds passed to consumer, release them. */
- /* Ensure we don't let the app know (sock = -1). */
- ustctl_release_object(-1, usess->metadata->stream_obj);
- ustctl_release_object(-1, usess->metadata->obj);
}
/* Send each channel fd streams of session */
}
/* Send each channel fd streams of session */
@@
-188,7
+186,8
@@
int ust_consumer_send_session(int consumer_fd, struct ust_app_session *usess)
while ((node = hashtable_iter_get_node(&iter)) != NULL) {
uchan = caa_container_of(node, struct ust_app_channel, node);
while ((node = hashtable_iter_get_node(&iter)) != NULL) {
uchan = caa_container_of(node, struct ust_app_channel, node);
- ret = send_channel_streams(sock, uchan);
+ ret = send_channel_streams(sock, uchan, usess->uid,
+ usess->gid);
if (ret < 0) {
rcu_read_unlock();
goto error;
if (ret < 0) {
rcu_read_unlock();
goto error;
This page took
0.025271 seconds
and
4
git commands to generate.