From f3eb6ef162778c396fcffefda3f3379fce5cab17 Mon Sep 17 00:00:00 2001 From: Lai Jiangshan Date: Sat, 13 Oct 2012 12:41:17 -0400 Subject: [PATCH] test_urcu_lfs: test for the proper pointer We should use "if (snode)" instead of "if (node)" in case of the struct cds_lfs_node_rcu is not the first field of struct node. Signed-off-by: Lai Jiangshan Signed-off-by: Mathieu Desnoyers --- tests/test_urcu_lfs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/test_urcu_lfs.c b/tests/test_urcu_lfs.c index 5886ce8..99d1b4c 100644 --- a/tests/test_urcu_lfs.c +++ b/tests/test_urcu_lfs.c @@ -242,13 +242,14 @@ void *thr_dequeuer(void *_count) for (;;) { struct cds_lfs_node_rcu *snode; - struct test *node; rcu_read_lock(); snode = cds_lfs_pop_rcu(&s); - node = caa_container_of(snode, struct test, list); rcu_read_unlock(); - if (node) { + if (snode) { + struct test *node; + + node = caa_container_of(snode, struct test, list); call_rcu(&node->rcu, free_node_cb); URCU_TLS(nr_successful_dequeues)++; } -- 2.34.1