From: Mathieu Desnoyers Date: Tue, 29 Sep 2009 00:16:15 +0000 (-0400) Subject: urcu-defer: use list instead of array for registry X-Git-Tag: v0.1~15 X-Git-Url: https://git.lttng.org/?p=urcu.git;a=commitdiff_plain;h=dbc6128f26035b2903e3278c6c41990c90831511 urcu-defer: use list instead of array for registry Signed-off-by: Mathieu Desnoyers --- diff --git a/urcu-defer-static.h b/urcu-defer-static.h index dd875ca..0493872 100644 --- a/urcu-defer-static.h +++ b/urcu-defer-static.h @@ -34,6 +34,7 @@ #include #include +#include /* @@ -120,6 +121,9 @@ struct defer_queue { unsigned long tail; /* next element to remove at tail */ void *last_fct_out; /* last fct pointer encoded */ void **q; + /* registry information */ + unsigned long last_head; + struct list_head list; /* list of thread queues */ }; #endif /* _URCU_DEFER_STATIC_H */ diff --git a/urcu-defer.c b/urcu-defer.c index e71b0cf..a38b5c0 100644 --- a/urcu-defer.c +++ b/urcu-defer.c @@ -57,19 +57,7 @@ static int defer_thread_futex; * the reclamation tread. */ static struct defer_queue __thread defer_queue; - -/* Thread IDs of registered deferers */ -#define INIT_NUM_THREADS 4 - -struct deferer_registry { - pthread_t tid; - struct defer_queue *defer_queue; - unsigned long last_head; -}; - -static struct deferer_registry *registry; -static int num_deferers, alloc_deferers; - +static LIST_HEAD(registry); static pthread_t tid_defer; static void internal_urcu_lock(pthread_mutex_t *mutex) @@ -121,12 +109,12 @@ static void wake_up_defer(void) static unsigned long rcu_defer_num_callbacks(void) { unsigned long num_items = 0, head; - struct deferer_registry *index; + struct defer_queue *index; internal_urcu_lock(&urcu_defer_mutex); - for (index = registry; index < registry + num_deferers; index++) { - head = LOAD_SHARED(index->defer_queue->head); - num_items += head - index->defer_queue->tail; + list_for_each_entry(index, ®istry, list) { + head = LOAD_SHARED(index->head); + num_items += head - index->tail; } internal_urcu_unlock(&urcu_defer_mutex); return num_items; @@ -197,7 +185,6 @@ static void _rcu_defer_barrier_thread(void) rcu_defer_barrier_queue(&defer_queue, head); } - void rcu_defer_barrier_thread(void) { internal_urcu_lock(&urcu_defer_mutex); @@ -220,16 +207,16 @@ void rcu_defer_barrier_thread(void) void rcu_defer_barrier(void) { - struct deferer_registry *index; + struct defer_queue *index; unsigned long num_items = 0; - if (!registry) + if (list_empty(®istry)) return; internal_urcu_lock(&urcu_defer_mutex); - for (index = registry; index < registry + num_deferers; index++) { - index->last_head = LOAD_SHARED(index->defer_queue->head); - num_items += index->last_head - index->defer_queue->tail; + list_for_each_entry(index, ®istry, list) { + index->last_head = LOAD_SHARED(index->head); + num_items += index->last_head - index->tail; } if (likely(!num_items)) { /* @@ -239,9 +226,8 @@ void rcu_defer_barrier(void) goto end; } synchronize_rcu(); - for (index = registry; index < registry + num_deferers; index++) - rcu_defer_barrier_queue(index->defer_queue, - index->last_head); + list_for_each_entry(index, ®istry, list) + rcu_defer_barrier_queue(index, index->last_head); end: internal_urcu_unlock(&urcu_defer_mutex); } @@ -337,62 +323,11 @@ void rcu_defer_queue(void (*fct)(void *p), void *p) _rcu_defer_queue(fct, p); } -static void rcu_add_deferer(pthread_t id) -{ - struct deferer_registry *oldarray; - - if (!registry) { - alloc_deferers = INIT_NUM_THREADS; - num_deferers = 0; - registry = - malloc(sizeof(struct deferer_registry) * alloc_deferers); - } - if (alloc_deferers < num_deferers + 1) { - oldarray = registry; - registry = malloc(sizeof(struct deferer_registry) - * (alloc_deferers << 1)); - memcpy(registry, oldarray, - sizeof(struct deferer_registry) * alloc_deferers); - alloc_deferers <<= 1; - free(oldarray); - } - registry[num_deferers].tid = id; - /* reference to the TLS of _this_ deferer thread. */ - registry[num_deferers].defer_queue = &defer_queue; - registry[num_deferers].last_head = 0; - num_deferers++; -} - -/* - * Never shrink (implementation limitation). - * This is O(nb threads). Eventually use a hash table. - */ -static void rcu_remove_deferer(pthread_t id) -{ - struct deferer_registry *index; - - assert(registry != NULL); - for (index = registry; index < registry + num_deferers; index++) { - if (pthread_equal(index->tid, id)) { - memcpy(index, ®istry[num_deferers - 1], - sizeof(struct deferer_registry)); - registry[num_deferers - 1].tid = 0; - registry[num_deferers - 1].defer_queue = NULL; - registry[num_deferers - 1].last_head = 0; - num_deferers--; - return; - } - } - /* Hrm not found, forgot to register ? */ - assert(0); -} - static void start_defer_thread(void) { int ret; - ret = pthread_create(&tid_defer, NULL, thr_defer, - NULL); + ret = pthread_create(&tid_defer, NULL, thr_defer, NULL); assert(!ret); } @@ -409,39 +344,42 @@ static void stop_defer_thread(void) void rcu_defer_register_thread(void) { - int deferers; + int was_empty; + + assert(defer_queue.last_head == 0); + assert(defer_queue.q == NULL); + defer_queue.q = malloc(sizeof(void *) * DEFER_QUEUE_SIZE); internal_urcu_lock(&defer_thread_mutex); internal_urcu_lock(&urcu_defer_mutex); - defer_queue.q = malloc(sizeof(void *) * DEFER_QUEUE_SIZE); - rcu_add_deferer(pthread_self()); - deferers = num_deferers; + was_empty = list_empty(®istry); + list_add(&defer_queue.list, ®istry); internal_urcu_unlock(&urcu_defer_mutex); - if (deferers == 1) + if (was_empty) start_defer_thread(); internal_urcu_unlock(&defer_thread_mutex); } void rcu_defer_unregister_thread(void) { - int deferers; + int is_empty; internal_urcu_lock(&defer_thread_mutex); internal_urcu_lock(&urcu_defer_mutex); - rcu_remove_deferer(pthread_self()); + list_del(&defer_queue.list); _rcu_defer_barrier_thread(); free(defer_queue.q); defer_queue.q = NULL; - deferers = num_deferers; + is_empty = list_empty(®istry); internal_urcu_unlock(&urcu_defer_mutex); - if (deferers == 0) + if (is_empty) stop_defer_thread(); internal_urcu_unlock(&defer_thread_mutex); } void urcu_defer_exit(void) { - free(registry); + assert(list_empty(®istry)); }