From: Mathieu Desnoyers Date: Tue, 8 Oct 2013 13:23:10 +0000 (-0400) Subject: Fix: urcu-qsbr: reversed logic on RCU_DEBUG X-Git-Tag: v0.9.0~136 X-Git-Url: https://git.lttng.org/?p=urcu.git;a=commitdiff_plain;h=d47b05cb05b91bb9679d127c51bc4beac12b899d Fix: urcu-qsbr: reversed logic on RCU_DEBUG * Dmitri Shubin wrote: > Shouldn't the condition in line 94 actually be > > 94 #if (!defined(BUILD_QSBR_LIB) && !defined(RCU_DEBUG)) > > So when RCU_DEBUG is _not_ defined we get static inlines for > rcu_read_{,un}lock() ? Indeed! Reported-by: Dmitri Shubin Signed-off-by: Mathieu Desnoyers --- diff --git a/urcu-qsbr.h b/urcu-qsbr.h index bb0523c..b4a28a7 100644 --- a/urcu-qsbr.h +++ b/urcu-qsbr.h @@ -91,7 +91,7 @@ extern "C" { * library debugging & tracing features we could come up with. */ -#if (!defined(BUILD_QSBR_LIB) && defined(RCU_DEBUG)) +#if (!defined(BUILD_QSBR_LIB) && !defined(RCU_DEBUG)) static inline void rcu_read_lock(void) {