X-Git-Url: https://git.lttng.org/?p=urcu.git;a=blobdiff_plain;f=urcu-call-rcu-impl.h;h=4e5879f381eadc8ebacd2efd079bfa588ac41c4b;hp=dca98e4ae073d45f93d8665235b715661f16c0ad;hb=0b8ab7df078a6d8e1439b1db5849638892e1cc83;hpb=ebfd2673f1ec2892bd3de86cd8bedc95ecf2a24e diff --git a/urcu-call-rcu-impl.h b/urcu-call-rcu-impl.h index dca98e4..4e5879f 100644 --- a/urcu-call-rcu-impl.h +++ b/urcu-call-rcu-impl.h @@ -48,15 +48,14 @@ struct call_rcu_data { /* - * Align the tail on cache line size to eliminate false-sharing - * with head. Small note, however: the "qlen" field, kept for - * debugging, will cause false-sharing between enqueue and - * dequeue. + * We do not align head on a different cache-line than tail + * mainly because call_rcu callback-invocation threads use + * batching ("splice") to get an entire list of callbacks, which + * effectively empties the queue, and requires to touch the tail + * anyway. */ struct cds_wfcq_tail cbs_tail; - /* Alignment on cache line size will add padding here */ - - struct cds_wfcq_head __attribute__((aligned(CAA_CACHE_LINE_SIZE))) cbs_head; + struct cds_wfcq_head cbs_head; unsigned long flags; int32_t futex; unsigned long qlen; /* maintained for debugging. */