Fix dummy node insertion bug

[urcu.git] / rculfhash.c

diff --git a/rculfhash.c b/rculfhash.c
index 189f8c831237edfe205c6461babadb765b537285..a736b868ae7dac21c1d4d60d561cfcfbb1d223e9 100644 (file)
--- a/rculfhash.c
+++ b/rculfhash.c
@@ -887,11 +887,15 @@ struct cds_lfht_node *_cds_lfht_add(struct cds_lfht *ht,
                                goto insert;
                        if (likely(clear_flag(iter)->p.reverse_hash > node->p.reverse_hash))
                                goto insert;
+                       /* dummy node is the first node of the identical-hash-value chain */
+                       if (dummy && clear_flag(iter)->p.reverse_hash == node->p.reverse_hash)
+                               goto insert;
                        next = rcu_dereference(clear_flag(iter)->p.next);
                        if (unlikely(is_removed(next)))
                                goto gc_node;
                        if ((mode == ADD_UNIQUE || mode == ADD_REPLACE)
                            && !is_dummy(next)
+                           && clear_flag(iter)->p.reverse_hash == node->p.reverse_hash
                            && !ht->compare_fct(node->key, node->key_len,
                                                clear_flag(iter)->key,
                                                clear_flag(iter)->key_len)) {
@@ -1341,6 +1345,7 @@ void cds_lfht_lookup(struct cds_lfht *ht, void *key, size_t key_len,
                next = rcu_dereference(node->p.next);
                if (likely(!is_removed(next))
                    && !is_dummy(next)
+                   && clear_flag(node)->p.reverse_hash == reverse_hash
                    && likely(!ht->compare_fct(node->key, node->key_len, key, key_len))) {
                                break;
                }