fix: don't display hostname if null

[lttngtop.git] / src / common.c

diff --git a/src/common.c b/src/common.c
index 500c80d674f9056ced114e75a54af1e04fc51fc2..0a38bf36423769d069eaed4accf28b47fce4e678 100644 (file)
--- a/src/common.c
+++ b/src/common.c
@@ -86,7 +86,7 @@ uint64_t get_context_ppid(const struct bt_ctf_event *event)
 
 uint64_t get_context_vtid(const struct bt_ctf_event *event)
 {
-       const struct definition *scope;
+       const struct bt_definition *scope;
        uint64_t vtid;
 
        scope = bt_ctf_get_top_level_scope(event, BT_STREAM_EVENT_CONTEXT);
@@ -101,7 +101,7 @@ uint64_t get_context_vtid(const struct bt_ctf_event *event)
 
 uint64_t get_context_vpid(const struct bt_ctf_event *event)
 {
-       const struct definition *scope;
+       const struct bt_definition *scope;
        uint64_t vpid;
 
        scope = bt_ctf_get_top_level_scope(event, BT_STREAM_EVENT_CONTEXT);
@@ -116,7 +116,7 @@ uint64_t get_context_vpid(const struct bt_ctf_event *event)
 
 uint64_t get_context_vppid(const struct bt_ctf_event *event)
 {
-       const struct definition *scope;
+       const struct bt_definition *scope;
        uint64_t vppid;
 
        scope = bt_ctf_get_top_level_scope(event, BT_STREAM_EVENT_CONTEXT);
@@ -147,7 +147,7 @@ char *get_context_comm(const struct bt_ctf_event *event)
 
 char *get_context_hostname(const struct bt_ctf_event *event)
 {
-       const struct definition *scope;
+       const struct bt_definition *scope;
        char *hostname;
 
        scope = bt_ctf_get_top_level_scope(event, BT_STREAM_EVENT_CONTEXT);
@@ -175,9 +175,10 @@ struct processtop *find_process_tid(struct lttngtop *ctx, int tid, char *comm)
 }
 
 struct processtop* add_proc(struct lttngtop *ctx, int tid, char *comm,
-               unsigned long timestamp)
+               unsigned long timestamp, char *hostname)
 {
        struct processtop *newproc;
+       struct host *host;
 
        /* if the PID already exists, we just rename the process */
        /* FIXME : need to integrate with clone/fork/exit to be accurate */
@@ -201,12 +202,22 @@ struct processtop* add_proc(struct lttngtop *ctx, int tid, char *comm,
                g_hash_table_insert(ctx->process_hash_table,
                                (gpointer) (unsigned long) tid, newproc);
                if (lookup_tid_list(tid)) {
-                       add_filter_tid_list(tid, newproc);
+                       add_filter_tid_list(newproc);
                }
                ctx->nbnewthreads++;
                ctx->nbthreads++;
        }
        newproc->comm = strdup(comm);
+       if (hostname) {
+               host = lookup_hostname_list(hostname);
+               if (!host)
+                       host = add_hostname_list(hostname, 0);
+               if (!newproc->host || (newproc->host != host))
+                       newproc->host = host;
+               if (is_hostname_filtered(hostname)) {
+                       add_filter_tid_list(newproc);
+               }
+       }
 
        return newproc;
 }
@@ -214,6 +225,8 @@ struct processtop* add_proc(struct lttngtop *ctx, int tid, char *comm,
 struct processtop* update_proc(struct processtop* proc, int pid, int tid,
                int ppid, int vpid, int vtid, int vppid, char *comm, char *hostname)
 {
+       struct host *host;
+
        if (proc) {
                proc->pid = pid;
                proc->tid = tid;
@@ -225,13 +238,14 @@ struct processtop* update_proc(struct processtop* proc, int pid, int tid,
                        free(proc->comm);
                        proc->comm = strdup(comm);
                }
-               if (hostname) {
-                       if (proc->hostname && strcmp(proc->hostname, hostname) != 0) {
-                               free(proc->hostname);
-                       }
-                       proc->hostname = strdup(hostname);
-                       if (lookup_hostname_list(hostname)) {
-                               add_filter_tid_list(tid, proc);
+               if (hostname && !proc->host) {
+                       host = lookup_hostname_list(hostname);
+                       if (!host)
+                               host = add_hostname_list(hostname, 0);
+                       if (!proc->host || (proc->host != host))
+                               proc->host = host;
+                       if (is_hostname_filtered(hostname)) {
+                               add_filter_tid_list(proc);
                        }
                }
        }
@@ -258,23 +272,25 @@ void death_proc(struct lttngtop *ctx, int tid, char *comm,
 }
 
 struct processtop* get_proc(struct lttngtop *ctx, int tid, char *comm,
-               unsigned long timestamp)
+               unsigned long timestamp, char *hostname)
 {
        struct processtop *tmp;
+
        tmp = find_process_tid(ctx, tid, comm);
-       if (tmp && strcmp(tmp->comm, comm) == 0)
+       if (tmp && strcmp(tmp->comm, comm) == 0) {
                return tmp;
-       return add_proc(ctx, tid, comm, timestamp);
+       }
+       return add_proc(ctx, tid, comm, timestamp, hostname);
 }
 
 struct processtop *get_proc_pid(struct lttngtop *ctx, int tid, int pid,
-               unsigned long timestamp)
+               unsigned long timestamp, char *hostname)
 {
        struct processtop *tmp;
        tmp = find_process_tid(ctx, tid, NULL);
        if (tmp && tmp->pid == pid)
                return tmp;
-       return add_proc(ctx, tid, "Unknown", timestamp);
+       return add_proc(ctx, tid, "Unknown", timestamp, hostname);
 }
 
 void add_thread(struct processtop *parent, struct processtop *thread)
@@ -369,6 +385,7 @@ void copy_process_table(gpointer key, gpointer value, gpointer new_table)
 void rotate_perfcounter() {
        int i;
        struct processtop *tmp;
+
        for (i = 0; i < lttngtop.process_table->len; i++) {
                tmp = g_ptr_array_index(lttngtop.process_table, i);
                g_hash_table_foreach(tmp->perf, reset_perf_counter, NULL);
@@ -565,7 +582,7 @@ enum bt_cb_ret handle_statedump_process_state(struct bt_ctf_event *call_data,
        struct processtop *proc;
        unsigned long timestamp;
        int64_t pid, tid, ppid, vtid, vpid, vppid;
-       char *procname;
+       char *procname, *hostname = NULL;
 
        timestamp = bt_ctf_get_timestamp(call_data);
        if (timestamp == -1ULL)
@@ -621,8 +638,8 @@ enum bt_cb_ret handle_statedump_process_state(struct bt_ctf_event *call_data,
 
        proc = find_process_tid(&lttngtop, tid, procname);
        if (proc == NULL)
-               proc = add_proc(&lttngtop, tid, procname, timestamp);
-       update_proc(proc, pid, tid, ppid, vpid, vtid, vppid, procname, NULL);
+               proc = add_proc(&lttngtop, tid, procname, timestamp, hostname);
+       update_proc(proc, pid, tid, ppid, vpid, vtid, vppid, procname, hostname);
 
        if (proc) {
                free(proc->comm);
@@ -655,18 +672,28 @@ struct tm format_timestamp(uint64_t timestamp)
 
 int *lookup_tid_list(int tid)
 {
-       if (!tid_list)
+       if (!tid_filter_list)
                return NULL;
 
-       return g_hash_table_lookup(tid_list, (gpointer) &tid);
+       return g_hash_table_lookup(tid_filter_list, (gpointer) &tid);
 }
 
-char *lookup_hostname_list(const char *hostname)
+struct host *lookup_hostname_list(const char *hostname)
 {
-       if (!hostname || !hostname_list)
+       if (!hostname || !global_host_list)
                return NULL;
 
-       return g_hash_table_lookup(hostname_list, (gpointer) hostname);
+       return g_hash_table_lookup(global_host_list, (gpointer) hostname);
+}
+
+int is_hostname_filtered(const char *hostname)
+{
+       struct host *host;
+
+       host = lookup_hostname_list(hostname);
+       if (host)
+               return host->filter;
+       return 0;
 }
 
 int *lookup_filter_tid_list(int tid)
@@ -674,14 +701,14 @@ int *lookup_filter_tid_list(int tid)
        return g_hash_table_lookup(global_filter_list, (gpointer) &tid);
 }
 
-void add_filter_tid_list(int tid, struct processtop *newproc)
+void add_filter_tid_list(struct processtop *proc)
 {
        unsigned long *hash_tid;
 
        hash_tid = malloc(sizeof(unsigned long));
-       *hash_tid = tid;
+       *hash_tid = proc->tid;
        g_hash_table_insert(global_filter_list,
-                       (gpointer) (unsigned long) hash_tid, newproc);
+                       (gpointer) (unsigned long) hash_tid, proc);
 }
 
 void remove_filter_tid_list(int tid)
@@ -689,3 +716,37 @@ void remove_filter_tid_list(int tid)
        g_hash_table_remove(global_filter_list,
                        (gpointer) (unsigned long) &tid);
 }
+
+struct host *add_hostname_list(char *hostname, int filter)
+{
+       struct host *host;
+
+       host = lookup_hostname_list(hostname);
+       if (host)
+               return host;
+
+       host = g_new0(struct host, 1);
+       host->hostname = strdup(hostname);
+       host->filter = filter;
+       g_hash_table_insert(global_host_list,
+                       (gpointer) host->hostname,
+                       (gpointer) host);
+
+       return host;
+}
+
+void update_hostname_filter(struct host *host)
+{
+       struct processtop *tmp;
+       int i;
+
+       for (i = 0; i < lttngtop.process_table->len; i++) {
+               tmp = g_ptr_array_index(lttngtop.process_table, i);
+               if (tmp->host == host) {
+                       if (host->filter)
+                               add_filter_tid_list(tmp);
+                       else
+                               remove_filter_tid_list(tmp->tid);
+               }
+       }
+}