From cda77256e7f0cbc8839f9c872b75e77cb1fb7d5c Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Thu, 15 Apr 2021 13:31:13 -0400 Subject: [PATCH] notification_send callback takes const event_notifier parameter The event parameter of the notification_send callback should be const, because it should not be modified, only read. Signed-off-by: Mathieu Desnoyers Change-Id: Iff6b7454bb4a87ed4a75d842f67e18e5a11be4dd --- include/lttng/ust-events.h | 2 +- src/lib/lttng-ust/event-notifier-notification.c | 8 ++++---- src/lib/lttng-ust/lttng-tracer-core.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/lttng/ust-events.h b/include/lttng/ust-events.h index ad739bd7..95b4698d 100644 --- a/include/lttng/ust-events.h +++ b/include/lttng/ust-events.h @@ -422,7 +422,7 @@ struct lttng_ust_event_notifier { struct lttng_ust_event_notifier_private *priv; /* Private event notifier interface */ int eval_capture; /* Need to evaluate capture */ - void (*notification_send)(struct lttng_ust_event_notifier *event_notifier, + void (*notification_send)(const struct lttng_ust_event_notifier *event_notifier, const char *stack_data, struct lttng_ust_notification_ctx *notif_ctx); diff --git a/src/lib/lttng-ust/event-notifier-notification.c b/src/lib/lttng-ust/event-notifier-notification.c index 4cfd1b15..51f10b2e 100644 --- a/src/lib/lttng-ust/event-notifier-notification.c +++ b/src/lib/lttng-ust/event-notifier-notification.c @@ -214,7 +214,7 @@ void capture_sequence(struct lttng_msgpack_writer *writer, static void notification_init(struct lttng_event_notifier_notification *notif, - struct lttng_ust_event_notifier *event_notifier) + const struct lttng_ust_event_notifier *event_notifier) { struct lttng_msgpack_writer *writer = ¬if->writer; @@ -270,7 +270,7 @@ void notification_append_empty_capture( lttng_msgpack_write_nil(¬if->writer); } -static void record_error(struct lttng_ust_event_notifier *event_notifier) +static void record_error(const struct lttng_ust_event_notifier *event_notifier) { struct lttng_event_notifier_group *event_notifier_group = event_notifier->priv->group; @@ -300,7 +300,7 @@ static void record_error(struct lttng_ust_event_notifier *event_notifier) static void notification_send(struct lttng_event_notifier_notification *notif, - struct lttng_ust_event_notifier *event_notifier) + const struct lttng_ust_event_notifier *event_notifier) { ssize_t ret; size_t content_len; @@ -360,7 +360,7 @@ void notification_send(struct lttng_event_notifier_notification *notif, } void lttng_event_notifier_notification_send( - struct lttng_ust_event_notifier *event_notifier, + const struct lttng_ust_event_notifier *event_notifier, const char *stack_data, struct lttng_ust_notification_ctx *notif_ctx) { diff --git a/src/lib/lttng-ust/lttng-tracer-core.h b/src/lib/lttng-ust/lttng-tracer-core.h index 096ed28f..4c93428a 100644 --- a/src/lib/lttng-ust/lttng-tracer-core.h +++ b/src/lib/lttng-ust/lttng-tracer-core.h @@ -87,7 +87,7 @@ void lttng_ust_dummy_get_value(void *priv, struct lttng_ust_ctx_value *value) __attribute__((visibility("hidden"))); void lttng_event_notifier_notification_send( - struct lttng_ust_event_notifier *event_notifier, + const struct lttng_ust_event_notifier *event_notifier, const char *stack_data, struct lttng_ust_notification_ctx *notif_ctx) __attribute__((visibility("hidden"))); -- 2.34.1