From 21d04cc41c966d687aab6e0ba60b2cb1466356ca Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Thu, 27 May 2021 10:44:38 -0400 Subject: [PATCH] Cleanup: remove useless lttng_ust_probe_supports_event_notifier LTTng-UST 2.13 bumps the accepted probe provider major version to 3, therefore we can remove the lttng_ust_probe_supports_event_notifier version check, which requires that the probe provider major version is >= 2, because it is now useless. Signed-off-by: Mathieu Desnoyers Change-Id: Id31581d2728f1197788ce4e7a79c6c494c444b08 --- src/lib/lttng-ust/lttng-events.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/src/lib/lttng-ust/lttng-events.c b/src/lib/lttng-ust/lttng-events.c index f8170f55..320d459e 100644 --- a/src/lib/lttng-ust/lttng-events.c +++ b/src/lib/lttng-ust/lttng-events.c @@ -1745,13 +1745,6 @@ void lttng_session_sync_event_enablers(struct lttng_ust_session *session) lttng_ust_tp_probe_prune_release_queue(); } -/* Support for event notifier is introduced by probe provider major version 2. */ -static -bool lttng_ust_probe_supports_event_notifier(const struct lttng_ust_probe_desc *probe_desc) -{ - return probe_desc->major >= 2; -} - static void lttng_create_event_notifier_if_missing( struct lttng_event_notifier_enabler *event_notifier_enabler) @@ -1805,18 +1798,6 @@ void lttng_create_event_notifier_if_missing( if (found) continue; - /* Check that the probe supports event notifiers, else report the error. */ - if (!lttng_ust_probe_supports_event_notifier(probe_desc)) { - ERR("Probe \"%s\" contains event \"%s:%s\" which matches an enabled event notifier, " - "but its version (%u.%u) is too old and does not implement event notifiers. " - "It needs to be recompiled against a newer version of LTTng-UST, otherwise " - "this event will not generate any notification.", - probe_desc->provider_name, - probe_desc->provider_name, desc->event_name, - probe_desc->major, - probe_desc->minor); - continue; - } /* * We need to create a event_notifier for this event probe. */ -- 2.34.1