From fc43866a40edfc7971a626a932da1afffc05a6c4 Mon Sep 17 00:00:00 2001 From: Jonathan Rajotte Date: Wed, 27 May 2020 21:29:05 -0400 Subject: [PATCH] Tests: Fix: 99% fill ratio for high buffer usage is too high for larger events MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit If the event being registered is bigger than 1% of a subbuffer, the 99% ratio cannot be achieved since the "last event" necessary to go over 99% will always be dropped by the tracer. e.g: DBG1 - 19:31:07.665963875 [Notification]: [notification-thread] High buffer usage condition being evaluated: threshold = 16220, highest usage = 16196 (in evaluate_buffer_usage_condition() at notification-thread-events.c:3733) We use a ratio of 90% to keep a little headroom. Signed-off-by: Jonathan Rajotte Signed-off-by: Jérémie Galarneau Change-Id: I06180735e0b5e88209b888e51cc83b4ac7d98193 --- tests/regression/tools/notification/notification.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/regression/tools/notification/notification.c b/tests/regression/tools/notification/notification.c index 90abc11de..e13979ee8 100644 --- a/tests/regression/tools/notification/notification.c +++ b/tests/regression/tools/notification/notification.c @@ -413,7 +413,7 @@ void test_notification_channel(const char *session_name, const char *channel_nam struct lttng_condition *dummy_condition = NULL; double low_ratio = 0.0; - double high_ratio = 0.99; + double high_ratio = 0.90; /* Set-up */ action = lttng_action_notify_create(); -- 2.34.1