From f5d98ed9e6017de4d7146fd4a19dad4dab5471e3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Wed, 18 Nov 2020 17:12:45 -0500 Subject: [PATCH 1/1] Fix: trigger: erroneous check for success of trigger creation MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit 6808ef55e added a check for `ret == 0` to determine if a trigger could be created from a payload. The function returns >= 0 on success, leading to crashes when a trigger is de-serialized. Signed-off-by: Jérémie Galarneau Change-Id: Icd769dcb04f7637aa1877436e9a5570e7f20b63b --- src/common/trigger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/trigger.c b/src/common/trigger.c index e69e72e07..e038fa81a 100644 --- a/src/common/trigger.c +++ b/src/common/trigger.c @@ -264,7 +264,7 @@ error: lttng_condition_put(condition); lttng_action_put(action); end: - if (ret == 0) { + if (ret >= 0) { *_trigger = trigger; } else { lttng_trigger_put(trigger); -- 2.34.1