From e9a2bd79cfeb5ec3f246fb0bba0e32823bb1a272 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Wed, 29 Mar 2023 13:41:26 -0400 Subject: [PATCH] Fix: file-descriptor: unnecessary assert in move constructor MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit There is no use in checking the current fd in the move constructor. This is probably a left-over from the inital move assignment operator. Signed-off-by: Jérémie Galarneau Change-Id: I416d2778784ddea448904118c940914c030bf399 --- src/common/file-descriptor.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/common/file-descriptor.hpp b/src/common/file-descriptor.hpp index 51f397bcf..8d6b64be4 100644 --- a/src/common/file-descriptor.hpp +++ b/src/common/file-descriptor.hpp @@ -29,8 +29,8 @@ public: file_descriptor& operator=(const file_descriptor&) = delete; file_descriptor& operator=(file_descriptor&&) = delete; - file_descriptor(file_descriptor&& other) noexcept { - LTTNG_ASSERT(_is_valid_fd(_raw_fd)); + file_descriptor(file_descriptor&& other) noexcept + { std::swap(_raw_fd, other._raw_fd); } -- 2.34.1