From e4650a96a51b8c5e5b2574b2defa981df07f5cd0 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Mon, 28 Oct 2019 16:26:48 -0400 Subject: [PATCH] Fix: relayd: don't put un-acquired viewer trace chunk reference MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit viewer_stream_create() should not release (put) the reference to the viewer_trace_chunk in its error path if it could not acquire a new reference in the first place. Signed-off-by: Jérémie Galarneau --- src/bin/lttng-relayd/viewer-stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/lttng-relayd/viewer-stream.c b/src/bin/lttng-relayd/viewer-stream.c index 25ee35e5c..f41bbe1a8 100644 --- a/src/bin/lttng-relayd/viewer-stream.c +++ b/src/bin/lttng-relayd/viewer-stream.c @@ -173,7 +173,7 @@ error: if (vstream) { viewer_stream_destroy(vstream); } - if (viewer_trace_chunk) { + if (viewer_trace_chunk && acquired_reference) { lttng_trace_chunk_put(viewer_trace_chunk); } return NULL; -- 2.34.1