From e196f4f4b3525e73313529bd34b08d5da408923f Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Fri, 31 Aug 2018 13:39:50 -0400 Subject: [PATCH 1/1] Test fix: leak of exclusions on allocation error MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Reported-by: Coverity Scan (1395328 Resource leak) Signed-off-by: Jérémie Galarneau --- tests/unit/test_ust_data.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/unit/test_ust_data.c b/tests/unit/test_ust_data.c index 2d31aa4b0..2acf3d906 100644 --- a/tests/unit/test_ust_data.c +++ b/tests/unit/test_ust_data.c @@ -184,7 +184,7 @@ static void test_create_ust_event_exclusion(void) struct lttng_event ev; char *name; char *random_name; - struct lttng_event_exclusion *exclusion; + struct lttng_event_exclusion *exclusion = NULL; struct lttng_event_exclusion *exclusion_copy = NULL; const int exclusion_count = 2; @@ -254,6 +254,7 @@ static void test_create_ust_event_exclusion(void) LTTNG_EVENT_EXCLUSION_NAME_AT(exclusion, 1), LTTNG_SYMBOL_NAME_LEN); ret = trace_ust_create_event(&ev, NULL, NULL, exclusion, false, &event); + exclusion = NULL; ok(ret == LTTNG_OK, "Create UST event with different exclusion names"); if (!event) { @@ -273,6 +274,7 @@ static void test_create_ust_event_exclusion(void) trace_ust_destroy_event(event); end: + free(exclusion); free(exclusion_copy); return; } -- 2.34.1