From df62dbcd26798ca35926f8316a1b5734e825b84b Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Tue, 9 Feb 2021 17:09:37 -0500 Subject: [PATCH 1/1] buffer-view: improve logging on creation failure MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérémie Galarneau Change-Id: Iddb902d6a02e69a3d2f02598c99a4a818bb4540c --- src/common/buffer-view.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/common/buffer-view.c b/src/common/buffer-view.c index 7337dbb06..04bd1ca35 100644 --- a/src/common/buffer-view.c +++ b/src/common/buffer-view.c @@ -34,12 +34,14 @@ struct lttng_buffer_view lttng_buffer_view_from_view( assert(src); if (offset > src->size) { - ERR("Attempt to create buffer view with invalid offset"); + ERR("Attempt to create buffer view from another view with invalid offset (offset > source size): source size = %zu, offset in source = %zu, length = %zd", + src->size, offset, len); goto end; } if (len != -1 && len > (src->size - offset)) { - ERR("Attempt to create buffer view with invalid length"); + ERR("Attempt to create buffer view from another view with invalid length (length > space left after offset in source): source size = %zu, offset in source = %zu, length = %zd", + src->size, offset, len); goto end; } @@ -59,12 +61,14 @@ struct lttng_buffer_view lttng_buffer_view_from_dynamic_buffer( assert(src); if (offset > src->size) { - ERR("Attempt to create buffer view with invalid offset"); + ERR("Attempt to create buffer view from a dynamic buffer with invalid offset (offset > source size): source size = %zu, offset in source = %zu, length = %zd", + src->size, offset, len); goto end; } if (len != -1 && len > (src->size - offset)) { - ERR("Attempt to create buffer view with invalid length"); + ERR("Attempt to create buffer view from a dynamic buffer with invalid length (length > space left after offset in source): source size = %zu, offset in source = %zu, length = %zd", + src->size, offset, len); goto end; } -- 2.34.1