From dd81b457300c29274b181b6f9cbd6d3f45610cd9 Mon Sep 17 00:00:00 2001 From: David Goulet Date: Tue, 14 May 2013 12:07:00 -0400 Subject: [PATCH] Fix: data leak in error path of cmd_register_consumer() Issue 1019923 of coverity scan. Signed-off-by: David Goulet --- src/bin/lttng-sessiond/cmd.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/bin/lttng-sessiond/cmd.c b/src/bin/lttng-sessiond/cmd.c index 528665a14..4eacb3c89 100644 --- a/src/bin/lttng-sessiond/cmd.c +++ b/src/bin/lttng-sessiond/cmd.c @@ -1831,7 +1831,7 @@ int cmd_register_consumer(struct ltt_session *session, int domain, const char *sock_path, struct consumer_data *cdata) { int ret, sock; - struct consumer_socket *socket; + struct consumer_socket *socket = NULL; assert(session); assert(cdata); @@ -1891,9 +1891,12 @@ int cmd_register_consumer(struct ltt_session *session, int domain, goto error; } - ret = LTTNG_OK; + return LTTNG_OK; error: + if (socket) { + consumer_destroy_socket(socket); + } return ret; } -- 2.34.1