From dc1c9a44fba1a368c283186e531c217206f5e816 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Thu, 12 Sep 2019 10:17:41 -0400 Subject: [PATCH] lttng: fix: potential 0-length allocation in pid list parsing MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Check that count is > 0 before allocating pid list. This would only happen after a prior error, but check it anyway. Signed-off-by: Jérémie Galarneau --- src/bin/lttng/commands/track-untrack.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/bin/lttng/commands/track-untrack.c b/src/bin/lttng/commands/track-untrack.c index 6db4288c5..3073996a9 100644 --- a/src/bin/lttng/commands/track-untrack.c +++ b/src/bin/lttng/commands/track-untrack.c @@ -131,6 +131,11 @@ int parse_pid_string(const char *_pid_string, /* For next loop */ one_pid_str = strtok_r(NULL, ",", &iter); } + if (count == 0) { + ERR("Fatal error occurred when parsing pid string"); + retval = CMD_ERROR; + goto error; + } free(pid_string); /* Identity of delimiter has been lost in first pass. */ -- 2.34.1