From dad01b0a32248a3accec24e763b354610321d228 Mon Sep 17 00:00:00 2001 From: Jonathan Rajotte Date: Tue, 22 Mar 2016 14:12:04 -0400 Subject: [PATCH 1/1] Fix: do not return error on LTTNG_ERR_SNAPSHOT_NODATA MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit A warning is fine since the user has no control on whether or not applications (or the kernel) have produced any event between the start of the tracing session and the recording of the snapshot. MI wise the command is not a success since nothing was recorded. The command line return code is CMD_SUCCESS. refs #1002 Signed-off-by: Jonathan Rajotte Signed-off-by: Jérémie Galarneau --- src/bin/lttng/commands/snapshot.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/bin/lttng/commands/snapshot.c b/src/bin/lttng/commands/snapshot.c index abdf18901..298bc6ef3 100644 --- a/src/bin/lttng/commands/snapshot.c +++ b/src/bin/lttng/commands/snapshot.c @@ -725,6 +725,15 @@ int cmd_snapshot(int argc, const char **argv) break; case LTTNG_ERR_SNAPSHOT_NODATA: WARN("%s", lttng_strerror(command_ret)); + + /* A warning is fine since the user has no control on + * whether or not applications (or the kernel) have + * produced any event between the start of the tracing + * session and the recording of the snapshot. MI wise + * the command is not a success since nothing was + * recorded. + */ + command_ret = 0; break; default: ERR("%s", lttng_strerror(command_ret)); -- 2.34.1