From d386b2341d96bbeeb1f89071614506c0ddbb9bcc Mon Sep 17 00:00:00 2001 From: David Goulet Date: Tue, 19 Jun 2012 11:15:38 -0400 Subject: [PATCH] Fix: unchecked pointer from getenv() for lttng create The lttng create command was not handling the return pointer from getenv("HOME") and was passing it to a strdup() call. (close #271) Signed-off-by: David Goulet --- src/bin/lttng/commands/create.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/bin/lttng/commands/create.c b/src/bin/lttng/commands/create.c index 2778ef553..eac261ac7 100644 --- a/src/bin/lttng/commands/create.c +++ b/src/bin/lttng/commands/create.c @@ -94,13 +94,14 @@ static int create_session() /* Auto output path */ if (opt_output_path == NULL) { - alloc_path = strdup(config_get_default_path()); + alloc_path = config_get_default_path(); if (alloc_path == NULL) { - ERR("Home path not found.\n \ + ERR("HOME path not found.\n \ Please specify an output path using -o, --output PATH"); ret = CMD_FATAL; goto error; } + alloc_path = strdup(alloc_path); if (have_name) { ret = asprintf(&traces_path, "%s/" DEFAULT_TRACE_DIR_NAME -- 2.34.1