From caa15afd11d8545ea2cae5650947386fbc07af64 Mon Sep 17 00:00:00 2001 From: Jonathan Rajotte Date: Wed, 4 Sep 2019 18:29:58 -0400 Subject: [PATCH] Fix: chunk state is not set when relayd does not support trace chunks MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Being explicit here enforces that for a lttng-relayd that does not support chunks, the queried chunk will never exist. This caused a lttng destroy command to hang during backward compatibility testing with older lttng-relayd. Signed-off-by: Jonathan Rajotte Signed-off-by: Jérémie Galarneau --- src/common/relayd/relayd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/common/relayd/relayd.c b/src/common/relayd/relayd.c index 49997015e..a9c2bb2c3 100644 --- a/src/common/relayd/relayd.c +++ b/src/common/relayd/relayd.c @@ -1480,6 +1480,8 @@ int relayd_trace_chunk_exists(struct lttcomm_relayd_sock *sock, if (!relayd_supports_chunks(sock)) { DBG("Refusing to check for trace chunk existence: relayd does not support chunks"); + /* The chunk will never exist */ + *chunk_exists = false; goto end; } -- 2.34.1