From c7a78aabfa0491974d4ffc188d72eb1e67c7344e Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Tue, 17 May 2016 12:17:05 -0400 Subject: [PATCH] Fix: unchecked posix_fadvise() return value MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Found by Coverity: CID 1019971 (#1 of 1): Unchecked return value from library (CHECKED_RETURN)2. check_return: Calling posix_fadvise(outfd, orig_offset - stream->max_sb_size, stream->max_sb_size, 4) without checking return value. This library function may fail and return an error code. Signed-off-by: Jérémie Galarneau --- src/common/consumer/consumer.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/common/consumer/consumer.c b/src/common/consumer/consumer.c index cb05a1eb4..321703a51 100644 --- a/src/common/consumer/consumer.c +++ b/src/common/consumer/consumer.c @@ -1232,6 +1232,7 @@ void lttng_consumer_should_exit(struct lttng_consumer_local_data *ctx) void lttng_consumer_sync_trace_file(struct lttng_consumer_stream *stream, off_t orig_offset) { + int ret; int outfd = stream->out_fd; /* @@ -1262,8 +1263,11 @@ void lttng_consumer_sync_trace_file(struct lttng_consumer_stream *stream, * defined. So it can be expected to lead to lower throughput in * streaming. */ - posix_fadvise(outfd, orig_offset - stream->max_sb_size, + ret = posix_fadvise(outfd, orig_offset - stream->max_sb_size, stream->max_sb_size, POSIX_FADV_DONTNEED); + if (ret) { + WARN("posix_fadvise() error (%i)", ret); + } } /* -- 2.34.1