From c738df170902f40de6d8e53c9f214a5308e4182b Mon Sep 17 00:00:00 2001 From: Francis Deslauriers Date: Thu, 5 Nov 2020 15:22:03 -0500 Subject: [PATCH] event-notifier: implement `lttng_trigger_needs_tracer_notifier()` function MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This function is used to tell if a trigger needs a tracer notifier. This depends on its condition and its actions. Signed-off-by: Francis Deslauriers Signed-off-by: Jérémie Galarneau Change-Id: Ie3c928ba1c705c32e4c2e4c6b6b22aa8c10837a9 --- include/lttng/trigger/trigger-internal.h | 9 ++++++++ src/common/trigger.c | 26 +++++++++++++++++++++++- 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/include/lttng/trigger/trigger-internal.h b/include/lttng/trigger/trigger-internal.h index 21c269bef..59fe771aa 100644 --- a/include/lttng/trigger/trigger-internal.h +++ b/include/lttng/trigger/trigger-internal.h @@ -196,4 +196,13 @@ enum lttng_error_code lttng_trigger_generate_bytecode( LTTNG_HIDDEN struct lttng_trigger *lttng_trigger_copy(const struct lttng_trigger *trigger); +/* + * A given trigger needs a tracer notifier if + * it has an event-rule condition, + * AND + * it has one or more sessiond-execution action. + */ +LTTNG_HIDDEN +bool lttng_trigger_needs_tracer_notifier(const struct lttng_trigger *trigger); + #endif /* LTTNG_TRIGGER_INTERNAL_H */ diff --git a/src/common/trigger.c b/src/common/trigger.c index ca082d139..ad0d5df1b 100644 --- a/src/common/trigger.c +++ b/src/common/trigger.c @@ -92,7 +92,6 @@ const struct lttng_condition *lttng_trigger_get_const_condition( return trigger ? trigger->condition : NULL; } - /* * Note: the lack of reference counting 'get' on the action object is normal. * This API was exposed as such in 2.11. The client is not expected to call @@ -1013,3 +1012,28 @@ end: lttng_payload_reset(©_buffer); return copy; } + +LTTNG_HIDDEN +bool lttng_trigger_needs_tracer_notifier(const struct lttng_trigger *trigger) +{ + bool needs_tracer_notifier = false; + const struct lttng_condition *condition = + lttng_trigger_get_const_condition(trigger); + + switch (lttng_condition_get_type(condition)) { + case LTTNG_CONDITION_TYPE_ON_EVENT: + needs_tracer_notifier = true; + goto end; + case LTTNG_CONDITION_TYPE_SESSION_CONSUMED_SIZE: + case LTTNG_CONDITION_TYPE_BUFFER_USAGE_HIGH: + case LTTNG_CONDITION_TYPE_BUFFER_USAGE_LOW: + case LTTNG_CONDITION_TYPE_SESSION_ROTATION_ONGOING: + case LTTNG_CONDITION_TYPE_SESSION_ROTATION_COMPLETED: + goto end; + case LTTNG_CONDITION_TYPE_UNKNOWN: + default: + abort(); + } +end: + return needs_tracer_notifier; +} -- 2.34.1