From c585b4b94a2f517485cdf1c2f3efe8d26e44b05d Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Fri, 31 Jan 2020 17:56:26 -0500 Subject: [PATCH] Clean-up: consumerd: remove unreachable code MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit 1412204 Logically dead code The indicated dead code may have performed some action; that action will never occur. In consumer_clear_unmonitored_channel: Code can never be reached because of a logical contradiction (CWE-561) Reported-by: Coverity Scan Signed-off-by: Jérémie Galarneau Change-Id: I116ba5127bf30d3cee1e5f002d7360bc4bc22098 --- src/common/consumer/consumer.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/common/consumer/consumer.c b/src/common/consumer/consumer.c index b649d198a..c6eb71d57 100644 --- a/src/common/consumer/consumer.c +++ b/src/common/consumer/consumer.c @@ -4272,11 +4272,6 @@ error_unlock: pthread_mutex_unlock(&stream->lock); pthread_mutex_unlock(&channel->lock); rcu_read_unlock(); - if (ret) { - goto error; - } - ret = LTTCOMM_CONSUMERD_SUCCESS; -error: return ret; } -- 2.34.1