From ba45d9f035c9601a47e2903b16746eb0804059f3 Mon Sep 17 00:00:00 2001 From: David Goulet Date: Wed, 1 Oct 2014 14:40:13 -0400 Subject: [PATCH] Fix: cmd snapshot record output can't be NULL The session daemon calls cmd_record_snapshot always with a valid pointer. Fixes Coverity issue 1047269. Signed-off-by: David Goulet --- src/bin/lttng-sessiond/cmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/bin/lttng-sessiond/cmd.c b/src/bin/lttng-sessiond/cmd.c index 1fd799f0d..dcb79dda2 100644 --- a/src/bin/lttng-sessiond/cmd.c +++ b/src/bin/lttng-sessiond/cmd.c @@ -3055,6 +3055,7 @@ int cmd_snapshot_record(struct ltt_session *session, uint64_t session_max_size = 0, max_stream_size = 0; assert(session); + assert(output); DBG("Cmd snapshot record for session %s", session->name); @@ -3074,7 +3075,7 @@ int cmd_snapshot_record(struct ltt_session *session, } /* Use temporary output for the session. */ - if (output && *output->ctrl_url != '\0') { + if (*output->ctrl_url != '\0') { ret = snapshot_output_init(output->max_size, output->name, output->ctrl_url, output->data_url, session->consumer, &tmp_output, NULL); -- 2.34.1