From b7e1aba3b4ca20d7efd006f2c0485eb3408ea80e Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Fri, 31 Jan 2020 18:04:49 -0500 Subject: [PATCH 1/1] Fix: unchecked return value of cds_lfht_destroy() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit 1412202 Unchecked return value If the function returns an error value, the error value may be mistaken for a normal value. In lttng_tracker_list_destroy: Value returned from a function is not checked for errors before being used (CWE-252) Reported-by: Coverity Scan Signed-off-by: Jérémie Galarneau Change-Id: I85c994440bc2cd5df0545fd1364dab462f98bc1c --- src/bin/lttng-sessiond/tracker.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/bin/lttng-sessiond/tracker.c b/src/bin/lttng-sessiond/tracker.c index 15779ce72..302971767 100644 --- a/src/bin/lttng-sessiond/tracker.c +++ b/src/bin/lttng-sessiond/tracker.c @@ -225,11 +225,14 @@ end: void lttng_tracker_list_destroy(struct lttng_tracker_list *tracker_list) { + int ret; + if (!tracker_list) { return; } lttng_tracker_list_reset(tracker_list); - cds_lfht_destroy(tracker_list->ht, NULL); + ret = cds_lfht_destroy(tracker_list->ht, NULL); + assert(!ret); free(tracker_list); } -- 2.34.1