From b6d816c549c67b05339722a503a8272f81022dc2 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Tue, 10 Sep 2019 20:24:20 -0400 Subject: [PATCH] Fix: only invoke PERROR() on failure to close sessiond_socket MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérémie Galarneau --- src/lib/lttng-ctl/destruction-handle.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/lib/lttng-ctl/destruction-handle.c b/src/lib/lttng-ctl/destruction-handle.c index b6a70bac6..f0ff0d4e1 100644 --- a/src/lib/lttng-ctl/destruction-handle.c +++ b/src/lib/lttng-ctl/destruction-handle.c @@ -420,7 +420,9 @@ enum lttng_error_code lttng_destroy_session_ext(const char *session_name, error: if (sessiond_socket >= 0) { ret = close(sessiond_socket); - PERROR("Failed to close the LTTng session daemon connection socket"); + if (ret < 0) { + PERROR("Failed to close the LTTng session daemon connection socket"); + } } if (handle) { lttng_destruction_handle_destroy(handle); -- 2.34.1