From b5e3b044d898fe910f93d3ffd737c55d4b34e4ab Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Wed, 10 Feb 2021 14:08:55 -0500 Subject: [PATCH 1/1] Fix: sessiond: kernel: leak of notifier rule on failure to init notifier MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Coverity reports: 1445768 Resource leak The system resource will not be reclaimed and reused, reducing the future availability of the resource. In kernel_create_event_notifier_rule: Leak of memory or pointers to system resources (CWE-404) Reported-by: Coverity Scan Signed-off-by: Jérémie Galarneau Change-Id: Ica3f414fb7640ecddf9affbcc359121b04a82277 --- src/bin/lttng-sessiond/kernel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/lttng-sessiond/kernel.c b/src/bin/lttng-sessiond/kernel.c index dcd33a1b7..2e920286c 100644 --- a/src/bin/lttng-sessiond/kernel.c +++ b/src/bin/lttng-sessiond/kernel.c @@ -2328,7 +2328,7 @@ static enum lttng_error_code kernel_create_event_notifier_rule( error_code_ret = trace_kernel_init_event_notifier_from_event_rule( event_rule, &kernel_event_notifier); if (error_code_ret != LTTNG_OK) { - goto error; + goto free_event; } kernel_event_notifier.event.token = event_notifier_rule->token; -- 2.34.1