From b42ada9013db5428c0fbca358e87c001f5b7e8c4 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Wed, 10 Feb 2021 17:24:21 -0500 Subject: [PATCH 1/1] Fix: sessiond: notification: unreachable code in switch-case MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit A copy paste error introduced in bc8daafb causes the initialization of the session credentials to not be initialized. Reported-by: Francis Deslauriers Signed-off-by: Jérémie Galarneau Change-Id: I50af722a498892bec764e115cfa6e9ca64302e05 --- src/bin/lttng-sessiond/notification-thread-events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/lttng-sessiond/notification-thread-events.c b/src/bin/lttng-sessiond/notification-thread-events.c index 16a7925d6..833b550f8 100644 --- a/src/bin/lttng-sessiond/notification-thread-events.c +++ b/src/bin/lttng-sessiond/notification-thread-events.c @@ -2610,9 +2610,9 @@ int handle_notification_thread_command_register_trigger( ret = evaluate_session_condition_for_client(condition, state, &evaluation, &object_uid, &object_gid); - break; LTTNG_OPTIONAL_SET(&object_creds.uid, object_uid); LTTNG_OPTIONAL_SET(&object_creds.gid, object_gid); + break; case LTTNG_OBJECT_TYPE_CHANNEL: ret = evaluate_channel_condition_for_client(condition, state, &evaluation, &object_uid, -- 2.34.1