From ad36f3a7d46a3b0a49ff271e1c8fe3a9a8e9042e Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Mon, 17 Feb 2020 19:46:18 -0500 Subject: [PATCH] Fix: relayd: live: unchecked poll set creation return value MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The fd_tracker_util_poll_create function can fail because of fd exhaustion or because the underlying epoll call fails. In both cases, report and handle the error. Signed-off-by: Jérémie Galarneau Change-Id: Ie79fdc011afda43395ac883c6648f983118cfddb --- src/bin/lttng-relayd/live.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/bin/lttng-relayd/live.c b/src/bin/lttng-relayd/live.c index 3ddafe2a1..06cfa5c7b 100644 --- a/src/bin/lttng-relayd/live.c +++ b/src/bin/lttng-relayd/live.c @@ -439,6 +439,10 @@ int create_named_thread_poll_set(struct lttng_poll_event *events, ret = fd_tracker_util_poll_create(the_fd_tracker, name, events, 1, LTTNG_CLOEXEC); + if (ret) { + PERROR("Failed to create \"%s\" poll file descriptor", name); + goto error; + } /* Add quit pipe */ ret = lttng_poll_add(events, thread_quit_pipe[0], LPOLLIN | LPOLLERR); -- 2.34.1