From aab0598f56aca0553f9beac7cac2baa340aa6702 Mon Sep 17 00:00:00 2001 From: Francis Deslauriers Date: Wed, 12 Feb 2020 18:19:29 -0500 Subject: [PATCH] Tests: triggers: Add syscall event rule condition kernel tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Francis Deslauriers Signed-off-by: Jérémie Galarneau Change-Id: I38eb7d1789f40b112ce1c92bf51d1c05a9f3398c Depends-on: lttng-ust: I5a800fc92e588c2a6a0e26282b0ad5f31c044479 --- tests/regression/Makefile.am | 1 + .../regression/tools/notification/Makefile.am | 6 +- .../tools/notification/notification.c | 96 +++++++++++++++++++ .../test_notification_kernel_syscall | 52 ++++++++++ 4 files changed, 152 insertions(+), 3 deletions(-) create mode 100755 tests/regression/tools/notification/test_notification_kernel_syscall diff --git a/tests/regression/Makefile.am b/tests/regression/Makefile.am index 4e7f454c0..cc645fd74 100644 --- a/tests/regression/Makefile.am +++ b/tests/regression/Makefile.am @@ -33,6 +33,7 @@ TESTS = tools/filtering/test_invalid_filter \ tools/notification/test_notification_kernel_error \ tools/notification/test_notification_kernel_buffer_usage \ tools/notification/test_notification_kernel_instrumentation \ + tools/notification/test_notification_kernel_syscall \ tools/notification/test_notification_multi_app \ tools/rotation/test_ust \ tools/rotation/test_kernel \ diff --git a/tests/regression/tools/notification/Makefile.am b/tests/regression/tools/notification/Makefile.am index fc8bec285..469d667f7 100644 --- a/tests/regression/tools/notification/Makefile.am +++ b/tests/regression/tools/notification/Makefile.am @@ -10,7 +10,7 @@ noinst_PROGRAMS = base_client notification rotation if NO_SHARED CLEANFILES = libpause_consumer.so libpause_consumer.so.debug -EXTRA_DIST = test_notification_ust_error test_notification_ust_buffer_usage test_notification_ust_event_rule_condition_exclusion test_notification_kernel_error test_notification_kernel_buffer_usage test_notification_kernel_instrumentation test_notification_multi_app base_client.c notification.c consumer_testpoints.c util_event_generator.sh +EXTRA_DIST = test_notification_ust_error test_notification_ust_buffer_usage test_notification_ust_event_rule_condition_exclusion test_notification_kernel_error test_notification_kernel_buffer_usage test_notification_kernel_instrumentation test_notification_kernel_syscall test_notification_multi_app base_client.c notification.c consumer_testpoints.c util_event_generator.sh else @@ -37,8 +37,8 @@ notification_LDADD = $(LIB_LTTNG_CTL) $(LIBTAP) -lm rotation_SOURCES = rotation.c rotation_LDADD = $(LIB_LTTNG_CTL) $(LIBTAP) -lm -noinst_SCRIPTS = test_notification_ust_error test_notification_ust_buffer_usage test_notification_ust_event_rule_condition_exclusion test_notification_kernel_error test_notification_kernel_buffer_usage test_notification_kernel_instrumentation test_notification_multi_app test_rotation util_event_generator.sh -EXTRA_DIST = test_notification_ust_error test_notification_ust_buffer_usage test_notification_ust_event_rule_condition_exclusion test_notification_kernel_error test_notification_kernel_buffer_usage test_notification_kernel_instrumentation test_notification_multi_app test_rotation util_event_generator.sh +noinst_SCRIPTS = test_notification_ust_error test_notification_ust_buffer_usage test_notification_ust_event_rule_condition_exclusion test_notification_kernel_error test_notification_kernel_buffer_usage test_notification_kernel_instrumentation test_notification_kernel_syscall test_notification_multi_app test_rotation util_event_generator.sh +EXTRA_DIST = test_notification_ust_error test_notification_ust_buffer_usage test_notification_ust_event_rule_condition_exclusion test_notification_kernel_error test_notification_kernel_buffer_usage test_notification_kernel_instrumentation test_notification_kernel_syscall test_notification_multi_app test_rotation util_event_generator.sh all-local: @if [ x"$(srcdir)" != x"$(builddir)" ]; then \ diff --git a/tests/regression/tools/notification/notification.c b/tests/regression/tools/notification/notification.c index 6b70840c7..26c8366c4 100644 --- a/tests/regression/tools/notification/notification.c +++ b/tests/regression/tools/notification/notification.c @@ -33,6 +33,7 @@ #include #include #include +#include #include #include #include @@ -1298,11 +1299,92 @@ end: lttng_unregister_trigger(trigger); lttng_trigger_destroy(trigger); lttng_action_destroy(action); + lttng_event_rule_destroy(event_rule); lttng_condition_destroy(condition); lttng_kernel_probe_location_destroy(location); return; } +static void test_syscall_event_rule_notification( + enum lttng_domain_type domain_type) +{ + int i, ret; + const int notification_count = 3; + enum lttng_notification_channel_status nc_status; + enum lttng_event_rule_status event_rule_status; + enum lttng_trigger_status trigger_status; + struct lttng_notification_channel *notification_channel = NULL; + struct lttng_condition *condition = NULL; + struct lttng_event_rule *event_rule = NULL; + struct lttng_action *action = NULL; + struct lttng_trigger *trigger = NULL; + const char * const trigger_name = "syscall_trigger"; + const char * const syscall_name = "openat"; + + action = lttng_action_notify_create(); + if (!action) { + fail("Failed to create notify action"); + goto end; + } + + notification_channel = lttng_notification_channel_create( + lttng_session_daemon_notification_endpoint); + ok(notification_channel, "Notification channel object creation"); + + event_rule = lttng_event_rule_syscall_create(); + ok(event_rule, "syscall event rule object creation"); + + event_rule_status = lttng_event_rule_syscall_set_pattern( + event_rule, syscall_name); + ok(event_rule_status == LTTNG_EVENT_RULE_STATUS_OK, + "Setting syscall event rule pattern: '%s'", syscall_name); + + condition = lttng_condition_event_rule_create(event_rule); + ok(condition, "Condition syscall event rule object creation"); + + /* Register the trigger for condition. */ + trigger = lttng_trigger_create(condition, action); + if (!trigger) { + fail("Failed to create trigger with syscall event rule condition and notify action"); + goto end; + } + + trigger_status = lttng_trigger_set_name(trigger, trigger_name); + ok(trigger_status == LTTNG_TRIGGER_STATUS_OK, + "Setting name to trigger '%s'", trigger_name); + + ret = lttng_register_trigger(trigger); + if (ret) { + fail("Failed to register trigger with syscall event rule condition and notify action"); + goto end; + } + + nc_status = lttng_notification_channel_subscribe( + notification_channel, condition); + ok(nc_status == LTTNG_NOTIFICATION_CHANNEL_STATUS_OK, + "Subscribe to tracepoint event rule condition"); + + resume_application(); + + for (i = 0; i < notification_count; i++) { + char *name = get_next_notification_trigger_name( + notification_channel); + + ok(strcmp(trigger_name, name) == 0, + "Received notification for the expected trigger name: '%s' (%d/%d)", + trigger_name, i + 1, notification_count); + free(name); + } +end: + suspend_application(); + lttng_notification_channel_destroy(notification_channel); + lttng_unregister_trigger(trigger); + lttng_trigger_destroy(trigger); + lttng_action_destroy(action); + lttng_condition_destroy(condition); + return; +} + int main(int argc, const char *argv[]) { int test_scenario; @@ -1424,6 +1506,7 @@ int main(int argc, const char *argv[]) /* Test cases that need the kernel tracer. */ assert(domain_type == LTTNG_DOMAIN_KERNEL); + diag("Test kprobe event rule notifications for domain %s", domain_type_string); @@ -1431,6 +1514,19 @@ int main(int argc, const char *argv[]) break; } + case 5: + { + plan_tests(10); + /* Test cases that need the kernel tracer. */ + assert(domain_type == LTTNG_DOMAIN_KERNEL); + + diag("Test syscall event rule notifications for domain %s", + domain_type_string); + + test_syscall_event_rule_notification(domain_type); + + break; + } default: abort(); } diff --git a/tests/regression/tools/notification/test_notification_kernel_syscall b/tests/regression/tools/notification/test_notification_kernel_syscall new file mode 100755 index 000000000..62c1e74d7 --- /dev/null +++ b/tests/regression/tools/notification/test_notification_kernel_syscall @@ -0,0 +1,52 @@ +#!/bin/bash +# +# Copyright (C) 2017 Jonathan Rajotte-Julien +# +# SPDX-License-Identifier: LGPL-2.1-only + +CURDIR=$(dirname "$0")/ +TESTDIR=$CURDIR/../../../ + +TMPDIR=$(mktemp -d) + +TESTAPP_STATE_PATH=$(mktemp -u "$TMPDIR/application_state.XXXXXXXXXX") + +NUM_TESTS=25 + +# shellcheck source=../../../utils/utils.sh +source "$TESTDIR/utils/utils.sh" +# shellcheck source=./util_event_generator.sh +source "$CURDIR/util_event_generator.sh" + +function test_kernel_syscall_notification +{ + kernel_event_generator_run_once_per_transition generate_syscalls \ + "$TESTAPP_STATE_PATH" 10 /proc/cpuinfo /proc/cmdline & + APP_PID=$! + + # Pass the syscall_generator_file for filtering + "$CURDIR/notification" 5 LTTNG_DOMAIN_KERNEL $APP_PID \ + "$TESTAPP_STATE_PATH" + + + kill -SIGUSR2 $APP_PID + wait $APP_PID 2> /dev/null +} + +if [ "$(id -u)" == "0" ]; then + validate_lttng_modules_present + + start_lttng_sessiond_notap + + test_kernel_syscall_notification + + stop_lttng_sessiond_notap + +else + # Kernel tests are skipped. + plan_tests $NUM_TESTS + skip 0 "Root access is needed. Skipping all kernel notification tests." $NUM_TESTS +fi + +# Just in case cleanup +rm -rf "$TMPDIR" -- 2.34.1