From 9ac61dbdc19140c00f345aae570f18abbe079852 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Fri, 31 Jan 2020 18:06:09 -0500 Subject: [PATCH] Clean-up: unchecked return value MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The return value of lttng_dynamic_buffer_set_size() is ignored in lttng_dynamic_array_clear(). It is okay as lttng_dynamic_buffer_set_size(..., 0) can't fail. However, it results in a Coverity Scan warning. 1412201 Unchecked return value If the function returns an error value, the error value may be mistaken for a normal value. In lttng_dynamic_array_clear: Value returned from a function is not checked for errors before being used (CWE-252) Reported-by: Coverity Scan Signed-off-by: Jérémie Galarneau Change-Id: I1943e299e4cb5752711f2d25b0dd9a5c44a28a18 --- src/common/dynamic-array.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/dynamic-array.c b/src/common/dynamic-array.c index f737c982d..198df19bb 100644 --- a/src/common/dynamic-array.c +++ b/src/common/dynamic-array.c @@ -89,7 +89,7 @@ void lttng_dynamic_array_clear(struct lttng_dynamic_array *array) } } - lttng_dynamic_buffer_set_size(&array->buffer, 0); + (void) lttng_dynamic_buffer_set_size(&array->buffer, 0); array->size = 0; } -- 2.34.1