From 9381314c87fe85771c05b01c85ca1c389eacb853 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Wed, 27 Mar 2019 15:31:13 -0400 Subject: [PATCH] Clarify incorrect channel output type logging message MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Recording a snapshot is only supported for channels that have an "mmap" output type. Add the channel's name and an explanation of the error in the consumer daemon's log as the channel's 'output' integral representation is of limited use. Signed-off-by: Jérémie Galarneau --- src/common/kernel-consumer/kernel-consumer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/common/kernel-consumer/kernel-consumer.c b/src/common/kernel-consumer/kernel-consumer.c index 246ae6b59..4e93bee91 100644 --- a/src/common/kernel-consumer/kernel-consumer.c +++ b/src/common/kernel-consumer/kernel-consumer.c @@ -144,7 +144,8 @@ static int lttng_kconsumer_snapshot_channel( /* Splice is not supported yet for channel snapshot. */ if (channel->output != CONSUMER_CHANNEL_MMAP) { - ERR("Unsupported output %d", channel->output); + ERR("Unsupported output type for channel \"%s\": mmap output is required to record a snapshot", + channel->name); ret = -1; goto end; } -- 2.34.1