From 8310270a50784aced2af5b21ab23bc7bd9dee47f Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Wed, 30 Jun 2021 18:41:24 -0400 Subject: [PATCH] lttng: add-trigger: print generated trigger name MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Print the generated trigger name when `add-trigger` succeeds. Also, no message is emited when a trigger is successfully registered as the command will print an error message if any error occurs. There is also no need to parrot the trigger's name if it was specified by the user. Signed-off-by: Jérémie Galarneau Change-Id: I9607fbd358298b036bd533834143eb5e9d185cd0 --- src/bin/lttng/commands/add_trigger.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/bin/lttng/commands/add_trigger.c b/src/bin/lttng/commands/add_trigger.c index e7809dc52..583dd1903 100644 --- a/src/bin/lttng/commands/add_trigger.c +++ b/src/bin/lttng/commands/add_trigger.c @@ -2406,9 +2406,22 @@ int cmd_add_trigger(int argc, const char **argv) if (ret_code != LTTNG_OK) { goto error; } + } else { + if (!name) { + const char *returned_trigger_name; + const enum lttng_trigger_status trigger_status = + lttng_trigger_get_name(trigger, + &returned_trigger_name); + + if (trigger_status != LTTNG_TRIGGER_STATUS_OK) { + WARN("Failed to retrieve the name generated for the added trigger."); + } else { + MSG("Added trigger '%s'.", + returned_trigger_name); + } + } } - MSG("Trigger registered successfully."); ret = 0; goto end; -- 2.34.1