From 73e38068d5e19fd338f29e897598b15ab5ae743b Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Tue, 10 Sep 2019 20:26:47 -0400 Subject: [PATCH] Fix: report bytecode_push failure when pushing symbol MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The last use of bytecode_push's return value is not checked in visit_node_load_expression_legacy(). Signed-off-by: Jérémie Galarneau --- src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c b/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c index 74ec1a715..0e778562f 100644 --- a/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c +++ b/src/lib/lttng-ctl/filter/filter-visitor-generate-bytecode.c @@ -295,6 +295,9 @@ int visit_node_load_expression_legacy(struct filter_parser_ctx *ctx, } ret = bytecode_push(&ctx->bytecode_reloc, symbol, 1, strlen(symbol) + 1); + if (ret) { + goto end; + } ret = 1; /* legacy */ end: free(insn); -- 2.34.1