From 45d6ecaaee3b2dd4d72f8de54a21ba2290f3b756 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9mie=20Galarneau?= Date: Thu, 5 Aug 2021 17:30:28 -0400 Subject: [PATCH] run-as: clean-up: handle_one_cmd: mark initial uid/gid as const MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Jérémie Galarneau Change-Id: Ia4fdf5b52a89bc499433550c0de8aeb50d3dea91 --- src/common/runas.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/common/runas.c b/src/common/runas.c index ab43423b1..db95429b4 100644 --- a/src/common/runas.c +++ b/src/common/runas.c @@ -1101,8 +1101,8 @@ int handle_one_cmd(struct run_as_worker *worker) ssize_t readlen, writelen; struct run_as_ret sendret = {}; run_as_fct cmd; - uid_t prev_ruid; - gid_t prev_rgid; + const uid_t prev_ruid = getuid(); + const gid_t prev_rgid = getgid(); /* * Stage 1: Receive run_as_data struct from the master. @@ -1140,9 +1140,6 @@ int handle_one_cmd(struct run_as_worker *worker) goto end; } - prev_ruid = getuid(); - prev_rgid = getgid(); - ret = demote_creds(prev_ruid, prev_rgid, data.uid, data.gid); if (ret < 0) { goto write_return; -- 2.34.1